Calendar Grid is not fully 0,0 when set to 0,0 Cell inset. It is off by one pixel when orientation changes. This seems to be an iOS issue. Workaround for now is to set the inset to some negative fractional value if you are experiencing the issue. #26

cbwilliamsnh · 2016-05-24T14:44:56Z

I have a three month calendar (June - Aug, 2016). I've attached three images.

First is how the calendar initially appears, second is when I scroll from June to July and third is when I scroll back to June.

Here's the additional code in my controller:

    calendarView.dataSource = self
    calendarView.delegate = self
    calendarView.registerCellViewXib(fileName: "ScheduleCellView")
    calendarView.backgroundColor = UIColor.whiteColor()
    calendarView.cellInset = CGPoint(x: 2, y: 2)

    let currentDate = calendarView.currentCalendarDateSegment()
    setupViewsOfCalendar(currentDate.startDate, endDate: currentDate.endDate)

setupViewsOfCalendar is from the tutorial.

The text was updated successfully, but these errors were encountered:

patchthecode · 2016-05-24T16:48:11Z

OK. first thing. I update this calendar quite a bit. Which version are you using?

cbwilliamsnh · 2016-05-24T16:50:49Z

Using JTAppleCalendar (3.0.0) // From pod install output

patchthecode · 2016-05-24T16:57:09Z

Note the latest version is 3.0.1
Can you do an update and let me know if it is fixed?

cbwilliamsnh · 2016-05-24T17:06:41Z

It is fixed!

Thank you!

patchthecode · 2016-05-24T17:12:28Z

And leave a like! :) its much needed. thanks!

cbwilliamsnh · 2016-05-24T17:16:24Z

Happy to do so (and did!)

Chuck

p.s. do I need to do anything special to support a touch or 3d touch?
Should I add that to the cell and the cell's controller?

love the cocoapod!

On Tue, May 24, 2016 at 1:13 PM, JTAppleCalendar [email protected]
wrote:

Hey mind putting that image of you calendar here?
I would really appreciate it. This is a new project and people needs to
see what can be done with it.
Can you post that image here? --> #2
#2
Wont bug you anymore if you do :]

—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#26 (comment)

Chuck

patchthecode · 2016-05-24T17:20:55Z

Touch and 3d touch? heh.. i dont even have an iPhone6 :(
I have not looked into 3d touch, but now that you mentioned it, i'll look into it in a bit. Well.. more like a bit bit.

And glad you enjoyed the pod. The others here on github was giving me a headache

cbwilliamsnh · 2016-05-24T17:25:48Z

FYI a cellInset of 0,0 still gives sketchy results on the grid display.

patchthecode · 2016-05-24T17:29:24Z

taking a look

patchthecode · 2016-05-24T17:32:35Z

It looks fine on mines

Are you free scrolling? or paged scrolling?
What happens with inset 0,0?

patchthecode · 2016-05-24T17:42:30Z

Ok i think i see something. It still leaves a space. It is a line that is off by one pixel.
Is this what you area talking about?

Fixing this issue now. It happens when i do an orientation change.

patchthecode · 2016-05-24T17:45:51Z

Hmm.. on second thought. I cant tell if it is an error without looking to see if it is on a real device. The line space disappears when i zoom in the iOS simulator by pressing the CMD + 1 or CMD + 2 or CMD + 3 keys. You will have to tell me specifically what you are seeing. Looking into it further

cbwilliamsnh · 2016-05-24T17:50:30Z

default scrolling (so paged?)

inset 0,0 gives results similar to the first image in the original issue.

On Tue, May 24, 2016 at 1:49 PM, JTAppleCalendar [email protected]
wrote:

It looks fine on mines

Are you free scrolling? or paged scrolling?

What happens with inset 0,0?

—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#26 (comment)

Chuck

cbwilliamsnh · 2016-05-24T18:04:34Z

Could be. I know that only some of the lines show when the inset is 0,0. My
app is portrait only so there is no orientation change.

On Tue, May 24, 2016 at 2:03 PM, JTAppleCalendar [email protected]
wrote:

Ok i think i see something. It still leaves a space. It is a line that is
off by one pixel.
Is this what you area talking about?

Fixing this issue now. It happens when i do an orientation change.

—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#26 (comment)

Chuck

cbwilliamsnh · 2016-05-24T18:13:17Z

When inset is 0, 0, this is what I see:

[image: Inline image 1]

Different lines are missing when I scroll the calendar, but the same lines
are missing on each month when I scroll back and forth.

On Tue, May 24, 2016 at 2:07 PM, JTAppleCalendar [email protected]
wrote:

Hmm.. on second thought. I cant tell if it is an error without looking to
see if it is on a real device. The line space disappears when i zoom in the
iOS simulator by pressing the CMD + 1 or CMD + 2 or CMD + 3 keys. You will
have to tell me specifically what you are seeing. Looking into it further

—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#26 (comment)

Chuck

patchthecode · 2016-05-24T18:14:26Z

not seeing the image. its not showing on github. But i think i get it. Similar issue? Alright. Will look into this

patchthecode · 2016-05-24T18:17:44Z

Tell you what. Set the inset to -1, -1 as a work around. I'll have to look into this after dinner

cbwilliamsnh · 2016-05-24T18:36:14Z

just for completeness, here's the screenshot.

Issue #26 #26 Cell inset 0,0 was not aligning properly

patchthecode · 2016-05-24T23:50:43Z

Ok, i have found fixed this issue and pushed it to github.
I have not released it in 3.0.2 yet just in case there is something else wrong with it (i dont think there should be though, i tested it much). Are you able to take a pull of master branch to see if it works for you?

patchthecode · 2016-05-25T00:03:44Z

I understand.
Ok, hmm.. i'm working on another upgrade you see. So i dont want to release another one yet. So here's what,

do a clone of this repository --> https://github.com/patchthecode/JTAppleCalendar.git
Next, just exchange these 3 files in your local cocoa pod folder, with these 3 files in the repository that you just cloned

The file names are:

JTAppleCalendarDelegate.swift
JTAppleCalendarFlowLayout.swift
JTAppleDayCell.swift

Once you replace these 3 files, you should now have the fix.
When I do the official release next week, you can just do your regular pod install command.

Let me know if the fix worked.

cbwilliamsnh · 2016-05-25T00:22:14Z

Thanks!

I'm working on another (unrelated) issue. As soon as that's solved I'll
give this a try.

Chuck

On Tue, May 24, 2016 at 8:03 PM, JTAppleCalendar [email protected]
wrote:

I understand.
Ok, hmm.. i'm working on another upgrade you see. So i dont want to
release another one yet. So here's what,

do a clone of this repository -->
https://github.com/patchthecode/JTAppleCalendar.git
Next, just exchange these 3 files in your local cocoa pod folder, with
these 3 files in the repository that you just cloned

The file names are:

JTAppleCalendarDelegate.swift

JTAppleCalendarFlowLayout.swift

JTAppleDayCell.swift

Once you replace these 3 files, you should now have the fix.
When I do the official release next week, you can just do your regular pod
install command.

Let me know if the fix worked.

—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#26 (comment)

Chuck

patchthecode · 2016-06-05T00:52:28Z

Should be fixed in version 4.0.0

hanishassim · 2016-06-22T17:22:06Z

I'm having the same problem too, I'm on the 4.0.3

You can see there is like a gap there. Note that I've placed the imageview cell and set constraint 0 on all sides, and content mode fill

patchthecode · 2016-06-22T18:30:17Z

@hanishassim is it possible you can give me a copy of your .xib file?
You can drag your file and drop it straight into a conversation box on github here. If that is possible for you.

patchthecode · 2016-06-22T18:40:32Z

Hmm. It seems ok there. Would it be possible if i could see the bugged project? Or is it private?

hanishassim · 2016-06-22T18:55:59Z

Could you share the screenshot? Sorry but I can't share the project..

patchthecode · 2016-06-22T18:59:47Z

Understood. Hmm. Alright then i'll have to debug this on my end. In the mean time, try setting the inset to (-0.5, -0.5) or (-1, -1) as a work around (you can choose what ever number you like). Will get back to you.

patchthecode · 2016-06-22T21:00:16Z

Ok. I just setup the calendar.
And mine is working properly.
So some questions about your calendar:

I see you December 2006 is being over lapped by the the black view. Are you doing anything extra in your configuration?
Also, i see in your xib, you're using UIImageViews instead of UIViews. Is every thing ok here?
Does this issue happen to the sample calendar project attached here on github?

hanishassim · 2016-06-24T02:16:37Z

I removed it, instead using the header for section xib now, no extra config used.
I'm using imagviews cause I want to apply calendar like airbnb's, they have date which is not selected, but set as blocked (not available for booking). Is still selectable if want to unbock it (which will remove the image view) .. Hmm is it okay to use the imageviews?
It does not happen in the sample cause the selectedView is round and not filling till the edges, so can't see if there is gap or not.

Attached is what I'm trying to achieve, like aribnb:

patchthecode · 2016-06-24T02:44:44Z

Alright then, so in order for me the recreate the (0,0) error it seems i have to create a selected background view that is not circular in shape. I will do as you did and use a UIImageView and fill the cell to see if i can recreate it.

And btw, you can use any view on your calendar. So long as it can be dragged unto the canvas, it can be used.

I will now attempt to recreate your pixel error.

hanishassim · 2016-06-24T02:49:41Z

thanks noted.

patchthecode · 2016-12-16T20:02:25Z

Closed.
Changed behavior of calendar.

if cellInset.x == 0 { cellInset.x = -0.1 }
if cellInset.y == 0 { cellInset.y = -0.1 }

Added Workaround - 1. // to handle #26 if cellInset.x == 0 { cellInset.x = -0.1 } if cellInset.y == 0 { cellInset.y = -0.1 } 2. Fixed issue #235

patchthecode self-assigned this May 24, 2016

patchthecode added the question label May 24, 2016

cbwilliamsnh closed this as completed May 24, 2016

cbwilliamsnh reopened this May 24, 2016

patchthecode added bug duplicate and removed question labels May 24, 2016

patchthecode added this to the Bugs 3.0 milestone May 24, 2016

patchthecode changed the title ~~Calendar grid not fully appearing and then disappears on scroll~~ Calendar Grid is not fully 0,0 when set to 0,0 Cell inset. There is a off by one pixel when orientation changes May 24, 2016

patchthecode removed the duplicate label May 24, 2016

patchthecode added a commit that referenced this issue May 24, 2016

Fixed bug

ab0921f

Issue #26 #26 Cell inset 0,0 was not aligning properly

patchthecode closed this as completed May 27, 2016

patchthecode reopened this May 31, 2016

patchthecode added the help wanted label May 31, 2016

patchthecode closed this as completed Jun 5, 2016

patchthecode reopened this Jun 22, 2016

patchthecode removed this from the Bugs 3.0 milestone Jul 14, 2016

patchthecode mentioned this issue Nov 23, 2016

cell issue #205

Closed

patchthecode mentioned this issue Dec 13, 2016

White line within calendar #227

Closed

patchthecode closed this as completed Dec 16, 2016

patchthecode added a commit that referenced this issue Dec 16, 2016

Fixed.

01fb9f4

Added Workaround - 1. // to handle #26 if cellInset.x == 0 { cellInset.x = -0.1 } if cellInset.y == 0 { cellInset.y = -0.1 } 2. Fixed issue #235

patchthecode added a commit that referenced this issue Dec 21, 2016

Fixed.

c696a02

Added Workaround - 1. // to handle #26 if cellInset.x == 0 { cellInset.x = -0.1 } if cellInset.y == 0 { cellInset.y = -0.1 } 2. Fixed issue #235

teh-obeng mentioned this issue Jul 11, 2017

White vertical line in calendar #480

Closed

rzzvn mentioned this issue Nov 3, 2019

Fatal Exception: CALayerInvalidGeometry CALayer bounds contains NaN #1173

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Calendar Grid is not fully 0,0 when set to 0,0 Cell inset. It is off by one pixel when orientation changes. This seems to be an iOS issue. Workaround for now is to set the inset to some negative fractional value if you are experiencing the issue. #26

Calendar Grid is not fully 0,0 when set to 0,0 Cell inset. It is off by one pixel when orientation changes. This seems to be an iOS issue. Workaround for now is to set the inset to some negative fractional value if you are experiencing the issue. #26

cbwilliamsnh commented May 24, 2016

patchthecode commented May 24, 2016

cbwilliamsnh commented May 24, 2016

patchthecode commented May 24, 2016

cbwilliamsnh commented May 24, 2016

patchthecode commented May 24, 2016

cbwilliamsnh commented May 24, 2016

patchthecode commented May 24, 2016 •

edited

Loading

cbwilliamsnh commented May 24, 2016

patchthecode commented May 24, 2016

patchthecode commented May 24, 2016

patchthecode commented May 24, 2016 •

edited

Loading

patchthecode commented May 24, 2016 •

edited

Loading

cbwilliamsnh commented May 24, 2016

cbwilliamsnh commented May 24, 2016

cbwilliamsnh commented May 24, 2016

patchthecode commented May 24, 2016 •

edited

Loading

patchthecode commented May 24, 2016

cbwilliamsnh commented May 24, 2016

patchthecode commented May 24, 2016

patchthecode commented May 25, 2016

cbwilliamsnh commented May 25, 2016

patchthecode commented Jun 5, 2016

hanishassim commented Jun 22, 2016

patchthecode commented Jun 22, 2016 •

edited

Loading

patchthecode commented Jun 22, 2016

hanishassim commented Jun 22, 2016

patchthecode commented Jun 22, 2016

patchthecode commented Jun 22, 2016

hanishassim commented Jun 24, 2016

patchthecode commented Jun 24, 2016 •

edited

Loading

hanishassim commented Jun 24, 2016

patchthecode commented Dec 16, 2016

Calendar Grid is not fully 0,0 when set to 0,0 Cell inset. It is off by one pixel when orientation changes. This seems to be an iOS issue. Workaround for now is to set the inset to some negative fractional value if you are experiencing the issue. #26

Calendar Grid is not fully 0,0 when set to 0,0 Cell inset. It is off by one pixel when orientation changes. This seems to be an iOS issue. Workaround for now is to set the inset to some negative fractional value if you are experiencing the issue. #26

Comments

cbwilliamsnh commented May 24, 2016

patchthecode commented May 24, 2016

cbwilliamsnh commented May 24, 2016

patchthecode commented May 24, 2016

cbwilliamsnh commented May 24, 2016

patchthecode commented May 24, 2016

cbwilliamsnh commented May 24, 2016

patchthecode commented May 24, 2016 • edited Loading

cbwilliamsnh commented May 24, 2016

patchthecode commented May 24, 2016

patchthecode commented May 24, 2016

patchthecode commented May 24, 2016 • edited Loading

patchthecode commented May 24, 2016 • edited Loading

cbwilliamsnh commented May 24, 2016

cbwilliamsnh commented May 24, 2016

cbwilliamsnh commented May 24, 2016

patchthecode commented May 24, 2016 • edited Loading

patchthecode commented May 24, 2016

cbwilliamsnh commented May 24, 2016

patchthecode commented May 24, 2016

patchthecode commented May 25, 2016

cbwilliamsnh commented May 25, 2016

patchthecode commented Jun 5, 2016

hanishassim commented Jun 22, 2016

patchthecode commented Jun 22, 2016 • edited Loading

patchthecode commented Jun 22, 2016

hanishassim commented Jun 22, 2016

patchthecode commented Jun 22, 2016

patchthecode commented Jun 22, 2016

hanishassim commented Jun 24, 2016

patchthecode commented Jun 24, 2016 • edited Loading

hanishassim commented Jun 24, 2016

patchthecode commented Dec 16, 2016

patchthecode commented May 24, 2016 •

edited

Loading

patchthecode commented May 24, 2016 •

edited

Loading

patchthecode commented May 24, 2016 •

edited

Loading

patchthecode commented May 24, 2016 •

edited

Loading

patchthecode commented Jun 22, 2016 •

edited

Loading

patchthecode commented Jun 24, 2016 •

edited

Loading