Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delegate and datasource strong refer #1081

Merged

Conversation

131e55
Copy link

@131e55 131e55 commented Jul 3, 2019

Hi! Thanks for releasing v8.0🎉

I probably found the cause of memory leak.
JTACMonthView.calendarDelegate and .calendarDataSource have strong reference.

JTACYearView has weak reference.

weak open var calendarDelegate: JTACYearViewDelegate?
weak open var calendarDataSource: JTACYearViewDataSource? {
    didSet { setupYearViewCalendar() }
}

So, I fixed JTACMonthView to have weak reference.

@131e55 131e55 marked this pull request as ready for review July 3, 2019 06:16
@patchthecode patchthecode merged commit 68e7d9b into patchthecode:master Jul 3, 2019
@patchthecode
Copy link
Owner

Thanks.
I missed that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants