Fix side effects in AWS Batch Executor test (apache#39474)

This wasted a lot of my hours in debugging failures for apache#39450 This was modifying a global env vars and causing side effects in other tests
pateash · May 13, 2024 · 2504644 · 2504644
1 parent 390576e
commit 2504644
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/tests/providers/amazon/aws/executors/batch/test_batch_executor.py b/tests/providers/amazon/aws/executors/batch/test_batch_executor.py
@@ -537,11 +537,9 @@ def test_start_health_check_config(self, set_env_vars):
         batch_mock.describe_jobs.side_effect = {}
         executor.batch = batch_mock
 
-        os.environ[f"AIRFLOW__{CONFIG_GROUP_NAME}__{AllBatchConfigKeys.CHECK_HEALTH_ON_STARTUP}".upper()] = (
-            "False"
-        )
-
-        executor.start()
+        env_var_key = f"AIRFLOW__{CONFIG_GROUP_NAME}__{AllBatchConfigKeys.CHECK_HEALTH_ON_STARTUP}".upper()
+        with mock.patch.dict(os.environ, {env_var_key: "False"}):
+            executor.start()
 
         batch_mock.describe_jobs.assert_not_called()