Skip to content

Commit

Permalink
Added new version
Browse files Browse the repository at this point in the history
  • Loading branch information
patrickschur committed Nov 16, 2019
1 parent 6cffdd1 commit 9d7a451
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 16 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# Change Log
All notable changes to this project will be documented in this file.

## [3.4.2] - 2019-11-16
### Changed
- Removed a build failure by using a newer version of PHPUnit

## [3.4.1] - 2019-11-16
### Changed
- Optimized performance by using fully-qualified function calls, thanks to [draco2003](https://github.com/draco2003)
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@
"ext-json": "*"
},
"require-dev": {
"phpunit/phpunit": "^7.5"
"phpunit/phpunit": "^8.4.3"
}
}
25 changes: 10 additions & 15 deletions tests/TrainerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,53 +41,48 @@ public function testFileIsWriteable()
}
}

/**
* @expectedException \LogicException
*/
public function testExceptionIsMinLengthGreaterThanMaxLength()
{
$this->expectException(\LogicException::class);

$t = new Trainer();

$t->setMaxLength(3);
$t->setMinLength(42);
}

/**
* @expectedException \LogicException
*/
public function testExceptionIsMinLengthLessThanZero()
{
$this->expectException(\LogicException::class);

$t = new Trainer();

$t->setMinLength(-42);
}

/**
* @expectedException \LogicException
*/
public function testExceptionIsMaxLengthLessThanMinLength()
{
$this->expectException(\LogicException::class);

$t = new Trainer();

$t->setMinLength(1);
$t->setMaxLength(0);
}

/**
* @expectedException \LogicException
*/
public function testExceptionIsMaxNgramsEqualToZero()
{
$this->expectException(\LogicException::class);

$t = new Trainer();

$t->setMaxNGrams(0);
}

/**
* @expectedException \LogicException
*/
public function testExceptionIsMaxNgramsLessThanZero()
{
$this->expectException(\LogicException::class);

$t = new Trainer();

$t->setMaxNGrams(-2);
Expand Down

0 comments on commit 9d7a451

Please sign in to comment.