Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view all is not working properly #452

Closed
gael-boyenval opened this issue Aug 25, 2016 · 0 comments
Closed

view all is not working properly #452

gael-boyenval opened this issue Aug 25, 2016 · 0 comments

Comments

@gael-boyenval
Copy link
Contributor

gael-boyenval commented Aug 25, 2016

I am using Pattern Lab Node v2.4.4 on Mac, with Node v6.3.1, using the Gulp Edition.

this bug seem to appear with version ^2.4.0. 2.3.0 is okay.
I'm using "styleguidekit-assets-default": "^3.3.0"

Expected Behavior

Click "view all" in the menu should display all patterns for a given category.
ex: atoms / view all => display all atoms

Actual Behavior

Click "view all" in the menu is displaying an error =>
ex: atoms / view all => display Cannot GET /patterns/01-atoms/index.html?1472134977808

if I enter manually http://localhost:3000/?p=viewall-atoms in the URL bar, everything is okay.

if I use a first or third level view all links => everything works fine.
I mean by that : the links corresponding to /?p=all page and /?p=viewall-folder-subfolder are ok

even more strange : for a given pattern view (01-atoms / 02-images / 00-logos / 01-logo-premium)

via menu => Cannot GET /patterns/01-atoms-02-images-00-logos-01-logo-premium/01-atoms-02-images-00-logos-01-logo-premium.rendered.html?1472135813584

via all items (default home page), clicking on the pattern title :
=> display the right page but no assets are loaded (no css nothing), and the url didn't change. ( still localhost:3000/ )/ in the console :

http://localhost:3000/patterns/01-atoms-02-images/css/main.css?1472134237407Failed to load resource: the server responded with a status of 404 (Not Found)


the browser try to fetch assets from the pattern folder… :(

But the previous behavior is true only for some patterns. the others are just fine.

update : the second problem come from nested folder ex: atoms/images/logos/pattern
the build work properly, and no error is displayed. moving folder logos into atoms seem to work fine.

I still think that support for nesting or error display should be implemented.

@gael-boyenval gael-boyenval changed the title view all not working in category menu view all is not working properly Aug 25, 2016
@bmuenzenmeyer bmuenzenmeyer added this to the 2.5.0 milestone Aug 30, 2016
@bmuenzenmeyer bmuenzenmeyer self-assigned this Aug 30, 2016
bmuenzenmeyer added a commit that referenced this issue Aug 30, 2016
@bmuenzenmeyer bmuenzenmeyer removed their assignment Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants