Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin our dependencies #684

Closed
bmuenzenmeyer opened this issue Sep 18, 2017 · 5 comments
Closed

Pin our dependencies #684

bmuenzenmeyer opened this issue Sep 18, 2017 · 5 comments
Labels
hacktoberfest 🌾 https://hacktoberfest.digitalocean.com staged for next release 🏁

Comments

@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Sep 18, 2017 •
edited
Loading

We should attempt to avoid problems like what happened at js-beautify/issues/1247 in the future.

https://github.com/pattern-lab/patternlab-node/blob/master/package.json#L11
@bmuenzenmeyer bmuenzenmeyer added the hacktoberfest 🌾 https://hacktoberfest.digitalocean.com label Sep 28, 2017
@ms10398
Copy link
Contributor

ms10398 commented Sep 28, 2017

I want to work on this can i know what I have to do in this

@bmuenzenmeyer
Copy link
Member Author

@ms10398 basically we need to remove the carets "^" from our dependencies defined within package.json so that they don't update without our knowledge

@ms10398
Copy link
Contributor

ms10398 commented Oct 1, 2017

Okay I will make a relevant PR soon.
Thanks @bmuenzenmeyer

@ms10398 ms10398 mentioned this issue Oct 1, 2017
Merged
@scarabcoder
Copy link

Is this still open?

@bmuenzenmeyer
Copy link
Member Author

bmuenzenmeyer commented Oct 13, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest 🌾 https://hacktoberfest.digitalocean.com staged for next release 🏁
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bmuenzenmeyer @scarabcoder @ms10398