-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: aligning and describing our Node support policy #1411
Merged
JosefBredereck
merged 7 commits into
pattern-lab:dev
from
mfranzke:docs/node-support-policy
Jan 29, 2022
Merged
docs: aligning and describing our Node support policy #1411
JosefBredereck
merged 7 commits into
pattern-lab:dev
from
mfranzke:docs/node-support-policy
Jan 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
especially as major version 12 reaches its end of life in three month
mfranzke
changed the title
docs: describing our Node support policy
docs: aligning and describing our Node support policy
Jan 29, 2022
JosefBredereck
requested changes
Jan 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked the text and only some minor recommendations.
Co-authored-by: Josef Bredreck <[email protected]>
Co-authored-by: Josef Bredreck <[email protected]>
Co-authored-by: Josef Bredreck <[email protected]>
Co-authored-by: Josef Bredreck <[email protected]>
Co-authored-by: Josef Bredreck <[email protected]>
Co-authored-by: Josef Bredreck <[email protected]>
JosefBredereck
approved these changes
Jan 29, 2022
PR was released with v5.16.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
As our currently used major Node version 12 reaches its end of life on 30th of April it might be important to set up a common understanding and communicate on how we would like to handle Node Major version updates, and especially on whether we always switch to either LTS or the oldest supported maintenance version. I would argue for the latter, as this would ensure the most "common ground" setups out there (especially that everybody on lower Node versions should update in their own best interests, regarding security, etc.).
The policy included has been adapted from the one by the conventional changelog project: https://github.com/conventional-changelog/conventional-changelog#node-support-policy