Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added styleGuideExcludes setting #174

Merged
merged 9 commits into from
Nov 6, 2015
Merged

Added styleGuideExcludes setting #174

merged 9 commits into from
Nov 6, 2015

Conversation

bramsmulders
Copy link
Contributor

I've added the styleGuideExcludes option in the config.
Here you can exclude templates from the styleguide(all view).

Fixes: #158

@bmuenzenmeyer
Copy link
Member

@bramsmulders you are an open source hero! Thanks so much for this work, and the poke. Looks pretty simple to merge in. I am almost done with #95 which is occupying most of my time, after which this will get my full attention. In the meantime, if you like, you could add a unit test. I am trying to cover more and more of patternlab node. If you don't I will do so.

Again, thanks again for knocking something out! Remind me if I don't get to this in a week or so. ⏳

@bmuenzenmeyer
Copy link
Member

Hi @bramsmulders I just finished #95 which likely broke the auto-merge of this feature. I've pulled this and reviewed. Looks good. I need to merge conflicts on my side using command line, which I'll do tomorrow or the next day or the next. Not enough energy to do so tonight.

Cheers

@bmuenzenmeyer bmuenzenmeyer merged commit 810c789 into pattern-lab:dev Nov 6, 2015
@bramsmulders
Copy link
Contributor Author

Hey @bmuenzenmeyer! Sorry for my late response, i was very busy pas couple of days. It is nice to see my pull request merged. I do not know anything about configuring unit tests, i'll poke around in the current unit tests you have here. Lets see if i can come up with something.

In the mean time this new styleguideExcludes setting also needs some documenting. I'll try to create a pull request for that this week.

@bmuenzenmeyer
Copy link
Member

I agree this should be documented. I am getting a bit hesitant to keep jamming things in the README as very soon there will be a home for node documentation on patternlab.io. Either way, you create something and I'm sure it will get sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants