Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root out a few more hard-coded paths #230

Merged
merged 3 commits into from
Jan 14, 2016

Conversation

geoffp
Copy link
Contributor

@geoffp geoffp commented Jan 8, 2016

That, and kill more file.substring(2)s that were a potential source of errors.

@bmuenzenmeyer
Copy link
Member

Morning @geoffp!

Thanks so much for this continued work

Looks like this fixes #222 ?

Since you have it up and running currently, could you do a quick check? Otherwise I can sometime this weekend.

@geoffp
Copy link
Contributor Author

geoffp commented Jan 8, 2016

Yeah! Let me look.

@geoffp
Copy link
Contributor Author

geoffp commented Jan 8, 2016

I just changed my patterns path to be absolute in config.json on this branch, and it seems to work!

@geoffp
Copy link
Contributor Author

geoffp commented Jan 8, 2016

Also, having fixed a bug pretty much by accident is a strange and wonderful feeling.

@EvanLovely
Copy link
Member

I know that file.substring(2) is the source of the problem in #222 – that'd be great if this fixed it!

@bmuenzenmeyer bmuenzenmeyer self-assigned this Jan 13, 2016
@bmuenzenmeyer
Copy link
Member

Great news. After a quick check of my own, I will get this merged.

Thanks for the teamwork guys 🍻

@bmuenzenmeyer
Copy link
Member

This passes a quick check, and is rather simple. Merging. Thanks geoff!

bmuenzenmeyer pushed a commit that referenced this pull request Jan 14, 2016
Root out a few more hard-coded paths
@bmuenzenmeyer bmuenzenmeyer merged commit 14797d9 into pattern-lab:dev Jan 14, 2016
@geoffp
Copy link
Contributor Author

geoffp commented Jan 14, 2016

🍺

@geoffp geoffp deleted the configurable-paths-galore branch January 20, 2016 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants