Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose several NPM packages #201

Closed
serenamarie125 opened this issue Jan 31, 2018 · 3 comments
Closed

Expose several NPM packages #201

serenamarie125 opened this issue Jan 31, 2018 · 3 comments

Comments

@serenamarie125
Copy link
Member

Currently, PatternFly React only exposes a single NPM package “patternfly-react” and exposes all modules within a single package in an automated semantic release process.

In the long term, it would be nice to expose several NPM packages in an automated semantic release process via a single repository, a “monorepo”. This will allow further breakdown of the distributions and reduce the dependency trees when installing patternfly-react packages, and enable us to continue reviewing packages together as a community in a single repository.

More notes on how Facebook did this here: https://reactjs.org/blog/2017/12/15/improving-the-repository-infrastructure.html

@priley86
Copy link
Member

priley86 commented Feb 12, 2018

Referencing our other discussion on this here too. Support for this is currently being added to semantic-releases upstream: semantic-release/semantic-release#193

@karelhala
Copy link
Contributor

I really like the idea of monorepo and splitting code into separate bundles which can be included one by one and make it easier to maintain and have much more sophisticated components in this repo. However I would not use multiple packages, that might be the end goal in future, but right now we can use webpack and it's libraries, where as entries for webpack we'd use function to look for all folders. You can check out this repo react-ui-components which basically does the same thing as we intend to do here.

@priley86
Copy link
Member

priley86 commented Feb 14, 2018

Responded in #218 regarding organization. I think using webpack to expose commonJS/AMD definitions here is a separate issue from this one now (as far as moving to automated semantic releases of monorepo is concerned).

Do you mind starting a separate issue on webpack library/AMD? I think right now, exposing our babel transpiled es6 modules is working fine, and we leave code splits to Webpack on the application end. However, I'm definitely open to ideas on this in the future... I am hearing good things about Rollup and other packaging libraries as well, but Babel is working great right now!

karelhala added a commit to karelhala/patternfly-react that referenced this issue Mar 1, 2018
divide files into multiple packages as monorepo and use lerna for semantic releases

BREAKING CHANGE: Introduces new package name, breaks whole repo into multiple packages

fix patternfly#201
karelhala added a commit to karelhala/patternfly-react that referenced this issue Mar 2, 2018
divide files into multiple packages as monorepo and use lerna for semantic releases

BREAKING CHANGE: Introduces new package name, breaks whole repo into multiple packages

fix patternfly#201
karelhala added a commit to karelhala/patternfly-react that referenced this issue Mar 3, 2018
divide files into multiple packages as monorepo and use lerna for semantic releases

BREAKING CHANGE: Introduces new package name, breaks whole repo into multiple packages

fix patternfly#201
karelhala added a commit to karelhala/patternfly-react that referenced this issue Mar 5, 2018
divide files into multiple packages as monorepo and use lerna for semantic releases

BREAKING CHANGE: Introduces new package name, breaks whole repo into multiple packages

fix patternfly#201
karelhala added a commit to karelhala/patternfly-react that referenced this issue Mar 5, 2018
divide files into multiple packages as monorepo and use lerna for semantic releases

BREAKING CHANGE: Introduces new package name, breaks whole repo into multiple packages

fix patternfly#201
karelhala added a commit to karelhala/patternfly-react that referenced this issue Mar 5, 2018
divide files into multiple packages as monorepo and use lerna for semantic releases

BREAKING CHANGE: Introduces new package name, breaks whole repo into multiple packages

fix patternfly#201
karelhala added a commit to karelhala/patternfly-react that referenced this issue Mar 8, 2018
divide files into multiple packages as monorepo and use lerna for semantic releases

BREAKING CHANGE: Introduces new package name, breaks whole repo into multiple packages

fix patternfly#201
karelhala added a commit to karelhala/patternfly-react that referenced this issue Mar 8, 2018
divide files into multiple packages as monorepo and use lerna for semantic releases

BREAKING CHANGE: Introduces new package name, breaks whole repo into multiple packages

fix patternfly#201
karelhala added a commit to karelhala/patternfly-react that referenced this issue Mar 8, 2018
divide files into multiple packages as monorepo and use lerna for semantic releases

BREAKING CHANGE: Introduces new package name, breaks whole repo into multiple packages

fix patternfly#201
karelhala added a commit to karelhala/patternfly-react that referenced this issue Mar 15, 2018
divide files into multiple packages as monorepo and use lerna for semantic releases

BREAKING CHANGE: Introduces new package name, breaks whole repo into multiple packages

fix patternfly#201
karelhala added a commit to karelhala/patternfly-react that referenced this issue Mar 27, 2018
divide files into multiple packages as monorepo and use lerna for semantic releases

BREAKING CHANGE: Introduces new package name, breaks whole repo into multiple packages

fix patternfly#201
karelhala added a commit to karelhala/patternfly-react that referenced this issue Mar 27, 2018
divide files into multiple packages as monorepo and use lerna for semantic releases

BREAKING CHANGE: Introduces new package name, breaks whole repo into multiple packages

fix patternfly#201
karelhala added a commit to karelhala/patternfly-react that referenced this issue Mar 27, 2018
divide files into multiple packages as monorepo and use lerna for semantic releases

BREAKING CHANGE: Introduces new package name, breaks whole repo into multiple packages

fix patternfly#201
karelhala added a commit to karelhala/patternfly-react that referenced this issue Mar 28, 2018
divide files into multiple packages as monorepo and use lerna for semantic releases

BREAKING CHANGE: Introduces new package name, breaks whole repo into multiple packages

fix patternfly#201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants