Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PF4: subTitleComponent is not used in ChartDonut #2486

Closed
bond95 opened this issue Jul 9, 2019 · 0 comments · Fixed by #2488
Closed

PF4: subTitleComponent is not used in ChartDonut #2486

bond95 opened this issue Jul 9, 2019 · 0 comments · Fixed by #2488
Assignees
@bond95
Milestone
2019.05

Comments

@bond95
Copy link
Contributor

bond95 commented Jul 9, 2019

ChartDonut component in function getSubTitle using prop titleComponent instead of subTitleComponent:

patternfly-react/packages/patternfly-4/react-charts/src/components/ChartDonut/ChartDonut.tsx

Lines 488 to 494 in aa99158

const getSubTitle = () => {
if (!subTitle || subTitlePosition === ChartDonutSubTitlePosition.center) {
return null;
}
const subTitleProps = titleComponent.props ? titleComponent.props : {};
return React.cloneElement(titleComponent, {
style: ChartDonutStyles.label.subTitle,

@bond95 bond95 mentioned this issue Jul 9, 2019
Merged
bond95 added a commit to bond95/patternfly-react that referenced this issue Jul 9, 2019
@bond95
fix(ChartDonut): Replaced prop titleComponent if function `getSubTi…
37a8688 
…tle` by `subTitleComponent`.

Previously `ChartDonut` component for building `subTitle` used prop `titleComponent`, while prop
`subTitleComponent` was unused. So in this PR `titleComponent` in `getSubtitle` was replaced by
`subTitleComponent`.

fix patternfly#2486
@bond95 bond95 mentioned this issue Jul 9, 2019
Merged
@tlabaj tlabaj added the PF4 label Jul 10, 2019
tlabaj pushed a commit that referenced this issue Jul 10, 2019
@bond95 @tlabaj
fix(ChartDonut): Replaced prop titleComponent if function `getSubTi…
18190a4 
…tle` by `subTitleComponent`. (#2488)

Previously `ChartDonut` component for building `subTitle` used prop `titleComponent`, while prop
`subTitleComponent` was unused. So in this PR `titleComponent` in `getSubtitle` was replaced by
`subTitleComponent`.

fix #2486
@rachael-phillips rachael-phillips added this to the Bluebird milestone Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bond95 bond95

Labels
None yet
Projects
None yet
Milestone
2019.05
Development

Successfully merging a pull request may close this issue.

fix(ChartDonut): Replaced prop titleComponent by subTitleComponent bond95/patternfly-react
3 participants
@bond95 @tlabaj @rachael-phillips