Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SerialConsole shows some extraneous components #340

Closed
jeff-phillips-18 opened this issue May 10, 2018 · 2 comments
Closed

SerialConsole shows some extraneous components #340

jeff-phillips-18 opened this issue May 10, 2018 · 2 comments

Comments

@jeff-phillips-18
Copy link
Member

The SerialConsole is now showing an extra text area and span:

image
@jeff-phillips-18
Copy link
Member Author

@mareklibra Any idea on this? Maybe some missing styling?

@mareklibra
Copy link
Contributor

mareklibra commented May 11, 2018 •
edited
Loading

right, styling is missing for the storybook, related to the #332

mareklibra added a commit to mareklibra/patternfly-react that referenced this issue May 11, 2018
@mareklibra
fix(storybook): add CSS styling to react-console storybook
47e11ed 
After splitting the project to monorepo, styling of subpackages is handled independently and must be
explicitely added to storybook.

ISSUES CLOSED: patternfly#340
@mareklibra mareklibra mentioned this issue May 11, 2018
Merged
jeff-phillips-18 pushed a commit that referenced this issue May 11, 2018
@mareklibra @jeff-phillips-18
chore(storybook): add CSS styling to react-console storybook (#341)
ca5763a 
After splitting the project to monorepo, styling of subpackages is handled independently and must be
explicitely added to storybook.

ISSUES CLOSED: #340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeff-phillips-18 @mareklibra