Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(label): added purple-50, updated green/purple fill colors #3138

Merged
merged 1 commit into from
Jun 17, 2020
Merged

fix(label): added purple-50, updated green/purple fill colors #3138

merged 1 commit into from
Jun 17, 2020

Conversation

mcoker
Copy link
Contributor

@mcoker mcoker commented May 27, 2020

fixes #3136
fixes #3137

@patternfly-build
Copy link

patternfly-build commented May 27, 2020 •
edited
Loading

Preview: https://patternfly-pr-3138.surge.sh

A11y report: https://patternfly-pr-3138-coverage.surge.sh

maryshak1996
maryshak1996 approved these changes May 27, 2020
View reviewed changes
Copy link

@maryshak1996 maryshak1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

mcarrano
mcarrano approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @mcoker . Thanks for turning it around so fast! @katierik also feel free to take a look.

mattnolting
mattnolting approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPTM 👍

christiemolloy
christiemolloy approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@christiemolloy christiemolloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@christiemolloy christiemolloy merged commit 1224e01 into patternfly:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattnolting mattnolting mattnolting approved these changes

@mcarrano mcarrano mcarrano approved these changes

@maryshak1996 maryshak1996 maryshak1996 approved these changes

@christiemolloy christiemolloy christiemolloy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mcoker @patternfly-build @mattnolting @mcarrano @maryshak1996 @christiemolloy