feat(modal-box): added support for title icon, modal alert states #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcoker
requested review from
mattnolting,
mcarrano,
christiemolloy,
mceledonia and
mmenestr
|
Preview: https://patternfly-pr-3487.surge.sh A11y report: https://patternfly-pr-3487-coverage.surge.sh
|
|
@mcarrano updated! |
mattnolting
approved these changes
Sep 29, 2020
|
Yes, good catch @mattnolting. I initially had it mocked up as 16px, not 8px (as it appears to be but not sure). |
christiemolloy
requested changes
Sep 30, 2020
| --pf-c-modal-box__title-icon--Color: var(--pf-c-modal-box--m-success__title-icon--Color); | ||
| } | ||
|
|
||
| &.pf-m-default { |
There was a problem hiding this comment.
do you need a modifier for default variation?
There was a problem hiding this comment.
I think so. Without a modifier, the icon is just a regular text color icon. With an alert modifier, it represents the alert state, and "default" is an alert state. WDYT?
| <i class="fas fa-info-circle" aria-hidden="true"></i> | ||
| {{else if modal-box--IsSuccessAlert}} | ||
| <i class="fas fa-check-circle" aria-hidden="true"></i> | ||
| {{else if modal-box--IsWarningAlert}} |
There was a problem hiding this comment.
should this use fa-fw so all the icons line up?
mmenestr
approved these changes
Sep 30, 2020
|
🎉 This PR is included in version 4.47.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3374