Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawer): fixed bottom variant issues in safari #3860

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

mcoker
Copy link
Contributor

@mcoker mcoker commented Feb 12, 2021

fixes #3857

flex-basis: 100% on __content isn't working in a vertical layout because its parent __main doesn't have a height.

@patternfly-build
Copy link

patternfly-build commented Feb 12, 2021

Preview: https://patternfly-pr-3860.surge.sh

CSS Size Report
NameCurrentPreviousDiff %
components/Drawer/drawer.css36.4 kB36.4 kB-0.01
components/Masthead/masthead.css28.8 kBNaN kBNaN
components/Page/page.css33.4 kB33.3 kB0.27
components/Table/table-tree-view.css2.8 kBNaN kBNaN
components/Table/table.css50.5 kB50.4 kB0.28
patternfly-no-reset.css1.1 MB1.0 MB2.73
patternfly.css1.1 MB1.0 MB2.73
patternfly.min.css956.4 kB929.1 kB2.86

A11y report: https://patternfly-pr-3860-coverage.surge.sh

Copy link
Member

@evwilkin evwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks! 🎉

@evwilkin
Copy link
Member

Looks like there are a11y issues related to tree table

Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto 🌮

@mcoker mcoker merged commit 89c5b17 into patternfly:master Feb 12, 2021
@redallen
Copy link
Contributor

🎉 This PR is included in version 4.87.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizable drawer bottom variant doesn't work in Safari
5 participants