Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(menu-toggle): added full height variant #4153

Merged
merged 2 commits into from
Jun 23, 2021

Conversation

mattnolting
Copy link
Contributor

closes #4149

@mattnolting mattnolting requested a review from mcoker June 16, 2021 15:09
@mattnolting mattnolting force-pushed the feat-menu-toggle-issue-4149 branch from f78328e to 35c162f Compare June 16, 2021 15:10
@patternfly-build
Copy link

patternfly-build commented Jun 16, 2021

Preview: https://patternfly-pr-4153.surge.sh

A11y report: https://patternfly-pr-4153-coverage.surge.sh

CSS Size Report
NameCurrentPreviousDiff %
components/MenuToggle/menu-toggle.css10.1 kB9.1 kB9.69
patternfly-no-reset.css1.2 MB1.2 MB0.08
patternfly.css1.2 MB1.2 MB0.08
patternfly.min.css1.1 MB1.1 MB0.09

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing!

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcoker mcoker merged commit 56d0e68 into patternfly:master Jun 23, 2021
@patternfly-build
Copy link

🎉 This PR is included in version 4.116.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pf-m-full-height to menu toggle
3 participants