feat(masthead): added horizontal nav demo #4617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattnolting
force-pushed
the
demo-masthead-4522
branch
from
fab6cd6 to
e465e0b
Compare
|
Preview: https://patternfly-pr-4617.surge.sh A11y report: https://patternfly-pr-4617-a11y.surge.sh |
mcarrano
requested changes
Jan 18, 2022
There was a problem hiding this comment.
@mattnolting Yes, there are a few things that should change here:
- We wouldn't recommend using this together with a vertical nav, so I think you should take that out.
- I'd be in favor of removing the context selector here. I don't think that we'd recommend having both that and a horizontal menu live together in the masthead.
- I believe that our design intent was to have the menu fill the full height of the masthead (I'm guessing that's what you mean by "full height).
@mceledonia do you agree with the above? Am I missing anything? The bottom line is that we rarely use a horizontal primary navigation and would only recommend it in a very simple use case which is why you don't see it often in product.
mattnolting
force-pushed
the
demo-masthead-4522
branch
from
e465e0b to
9df938e
Compare
mcarrano
approved these changes
Jan 18, 2022
|
🎉 This PR is included in version 4.169.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4522
@mcarrano @mceledonia can you please review Masthead with horizontal nav? A couple of things in question, bearing in mind that space becomes much more limited in this iteration.
__brandto be accommodated.