chore(form): add complex form demo #4865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-pr-4865.surge.sh A11y report: https://patternfly-pr-4865-a11y.surge.sh |
mcarrano
approved these changes
May 23, 2022
There was a problem hiding this comment.
@srambach I like the approach here. Agree that it seems much clearer. @mceledonia @mmenestr perhaps also take a look?
|
Agreed, this looks much cleaner/clearer!! Thanks @srambach |
mmenestr
approved these changes
May 24, 2022
mcoker
reviewed
May 26, 2022
| {{#> form-field-group-header}} | ||
| {{#> form-field-group-header-main}} | ||
| {{#> form-field-group-title}} | ||
| {{#> form-field-group-title-text}}Field group 1{{/form-field-group-title-text}} | ||
| {{#> form-field-group-title-text}}Field group Title{{/form-field-group-title-text}} |
There was a problem hiding this comment.
nit - sentence case?
Suggested change
| {{#> form-field-group-title-text}}Field group Title{{/form-field-group-title-text}} | |
| {{#> form-field-group-title-text}}Field group title{{/form-field-group-title-text}} |
| {{/label-group-list}} | ||
| {{/label-group-main}} | ||
| {{/label-group}} | ||
| {{#> text-input-group-text}} |
There was a problem hiding this comment.
there is some indentation off in this file (more than this spot). Just a nit if you have time, not required to merge though.
| {{#> form-group form-group--id=(concat form-field-group--id "-add-readiness")}} | ||
|
|
||
| {{#> form-group-control}} | ||
| {{#> button button--modifier="pf-m-link pf-m-inline"}} |
mcoker
approved these changes
May 27, 2022
|
🎉 This PR is included in version 4.196.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the existing nested field group example to scope it to just nested field groups, and moves and expands the existing demo to the HTML demos.
Fixes #4148