Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4854 fix(notification-badge): fixes documentation links #4891

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

blfetche
Copy link
Contributor

@blfetche blfetche commented Jun 3, 2022

Fixes #4854

fix(notification-badge): fixes documentation links

@blfetche blfetche requested a review from srambach June 3, 2022 14:30
@patternfly-build
Copy link

patternfly-build commented Jun 3, 2022

@srambach
Copy link
Member

srambach commented Jun 3, 2022

Great job getting your first PR in! 🎉
Is there one more link to fix in RELEASE-NOTES.md, way down in the 2020.7 section?

@blfetche
Copy link
Contributor Author

blfetche commented Jun 6, 2022

@srambach Thanks will take a look.

@blfetche
Copy link
Contributor Author

blfetche commented Jun 7, 2022

@srambach recommitted an update to release-notes.md to correct the upgrade links issue

@blfetche blfetche self-assigned this Jun 7, 2022
Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! ✨

@blfetche
Copy link
Contributor Author

blfetche commented Jun 7, 2022

Thanks again @srambach for all your help in getting me this far :)

@blfetche blfetche merged commit 91fcee3 into patternfly:main Jun 7, 2022
@patternfly-build
Copy link

🎉 This PR is included in version 4.196.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links in docs
3 participants