Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor accepts logger: parameter #17

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

andreibondarev
Copy link
Collaborator

      logger = Logger.new($stdout)
      client = Qdrant::Client.new(
        url: "localhost:8080",
        api_key: "123",
        logger: logger
      )

@andreibondarev andreibondarev merged commit e53e62f into main Oct 1, 2024
4 checks passed
@andreibondarev andreibondarev deleted the constructor-accepts-logger branch October 1, 2024 21:48
@inspire22
Copy link

Hmm, the default now seems to log absolutely everything to sdtout, which was a bit of a surprise when I upgraded to the latest qdrant client...

What was the default before? I liked it :)

@andreibondarev
Copy link
Collaborator Author

logger = Logger.new($stdout)

Well you should be able to change the logger.level to whatever you'd like! https://ruby-doc.org/stdlib-2.4.0/libdoc/logger/rdoc/Logger.html

@inspire22
Copy link

Hmm, I can't set it inline though, so this actually doubles (to 4) the number of lines qdrant is adding to my project :) Which seems like a silly complaint but I use ruby because I love elegant code :) Ideally the default logger level should be something reasonable lie it was before...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants