Add defaultSizeKey
#129
Merged
Add defaultSizeKey
#129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paularmstrong
approved these changes
Feb 18, 2020
| expect(state.sizeKey).toBe('stat'); | ||
| }); | ||
|
|
||
| test('resets the sizeKey to the first in list if both the current and the default are not in the new set', () => { |
|
@paularmstrong I've just realised that the Comparator should also honour this. Currently the default is hardcoded to build-tracker/src/comparator/src/index.ts Line 352 in b621ac7 If that makes sense to you I can try to raise another PR for that. |
|
Whoops! Yeah that sounds good. Maybe time to also think about making all the configuration a little more automatic with the way it spreads through the various parts of Build Tracker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Re. #14 (comment)
Solution
Explain your approach. Sometimes it helps to justify your approach against some others that you didn't choose to explain why yours is better.
TODO
yarn lint:ci,yarn test,yarn tsc:ci)