Merge pull request #67 from bobstanden/fix-srv-compression

RFC2782, page 3: DNS SRV Target must not be compressed
paulc · Jul 8, 2024 · a0abc9b · a0abc9b
2 parents eecd741 + 9627f80
commit a0abc9b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/dnslib/dns.py b/dnslib/dns.py
@@ -1460,7 +1460,7 @@ def get_target(self):
 
     def pack(self,buffer):
         buffer.pack("!HHH",self.priority,self.weight,self.port)
-        buffer.encode_name(self.target)
+        buffer.encode_name_nocompress(self.target)
 
     def __repr__(self):
         return "%d %d %d %s" % (self.priority,self.weight,self.port,self.target)

diff --git a/dnslib/label.py b/dnslib/label.py
@@ -294,7 +294,7 @@ def encode_name(self,name):
     def encode_name_nocompress(self,name):
         """
             Encode and store label with no compression
-            (needed for RRSIG)
+            (needed for RRSIG, SRV, NSEC)
         """
         if not isinstance(name,DNSLabel):
             name = DNSLabel(name)