Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis & AppVeyor to allow node 0.10 failures #659

Merged
merged 3 commits into from
Dec 29, 2017

Conversation

phated
Copy link
Contributor

@phated phated commented Dec 29, 2017

I believe this is the correct configuration but I'm still waiting on my AppVeyor to run.

@es128

@phated
Copy link
Contributor Author

phated commented Dec 29, 2017

Woot, my AppVeyor had a node 0.10 failure but the suite is marked as successful so it looks like everything is working.

.travis.yml Outdated
- '0.10'
os:
- linux
- osx
script:
- npm run ci-test
sudo: false
matrix:
allow_failures:
- node_js: '0.10'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.10 is actually reliable enough on Travis. There are random failures on OS X all the time, but Travis makes it easy enough to restart the specific items until they pass.

I don't think we need this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'll remove

@phated
Copy link
Contributor Author

phated commented Dec 29, 2017

Amended and force-pushed.

@coveralls
Copy link

coveralls commented Dec 29, 2017

Coverage Status

Coverage remained the same at 98.477% when pulling ab98207 on phated:ci-updates into 51ca0d5 on paulmillr:master.

@coveralls
Copy link

coveralls commented Dec 29, 2017

Coverage Status

Coverage remained the same at 98.477% when pulling fe97886 on phated:ci-updates into 51ca0d5 on paulmillr:master.

@phated
Copy link
Contributor Author

phated commented Dec 29, 2017

@es128 coveralls API is being super flakey so I moved the coverage upload to after_script like we do for gulpjs repos

Do you expect v2 to be released today? I'm really hoping to get gulp4 finalized and published to npm before Jan1

@es128
Copy link
Contributor

es128 commented Dec 29, 2017

@phated idk whether it will work out to publish today.

Should we add node v9 to the CI configs in this PR?

@phated
Copy link
Contributor Author

phated commented Dec 29, 2017

Sure, I'll update shortly. What other things will we be waiting on? I have bandwidth to help out

@coveralls
Copy link

coveralls commented Dec 29, 2017

Coverage Status

Coverage remained the same at 98.477% when pulling febd028 on phated:ci-updates into 51ca0d5 on paulmillr:master.

@es128
Copy link
Contributor

es128 commented Dec 29, 2017

Off the top of my head: a new changelog entry and updating the readme appveyor badge to the new paulmillr path

@phated
Copy link
Contributor Author

phated commented Dec 29, 2017

On it!

@es128 es128 merged commit 77cf90f into paulmillr:master Dec 29, 2017
@coveralls
Copy link

coveralls commented Dec 29, 2017

Coverage Status

Coverage remained the same at 98.477% when pulling d2d8132 on phated:ci-updates into 51ca0d5 on paulmillr:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.477% when pulling d2d8132 on phated:ci-updates into 51ca0d5 on paulmillr:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants