-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent LICENSE, README.rst, and HISTORY.rst from being installed in site-packages #135
Conversation
…site-packages Also let poetry find packages automatically rather than specify them explicitly
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 7 7
Lines 341 341
=======================================
Hits 328 328
Misses 13 13 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@J-M0 Thanks for PR!
Will include this into the next yaspin release.
Published in v2.1.0 |
Hello, I arrived here when searching how to fix an analogous problem we are having with our poetry releases. Did this solution work for you? We are trying something analogous with our repo and the magic I notice when I download the wheel for yaspin the files aren't included at all, so maybe this didn't work as expected? tar -ztf ~/Downloads/yaspin-2.1.0-py3-none-any.whl The source distribution has your additional files at the top level: tar -ztf ~/Downloads/yaspin-2.1.0.tar.gz |
Hello @cmungall The idea was to remove those files from |
Putting LICENSE, README.rst, and HISTORY.rst in the
include
section of pyproject.toml will cause those files to be included in the final wheel and result in them ending up insite-packages
when yaspin is installed.Poetry automatically includes LICENSE and README.rst in the sdist and wheel so they do not need to be specified. Also poetry will automatically pick up all files in a package so
yaspin/data/spinners.json
does not need to be specified either.HISTORY.rst does need to be explicitly included, but should only be in the sdist.
See python-poetry/poetry#2015 (comment) for details