add version command; fix get_server etc.

.goreleaser.yaml

@@ -18,6 +18,12 @@ before:
 builds:
 - env:
   - CGO_ENABLED=0
+  ldflags:
+  - -s -w -trimpath
+  - -X {{ .ModulePath }}/internal/version.Version={{.Version}}
+  - -X {{ .ModulePath }}/internal/version.Commit={{.Commit}}
+  - -X {{ .ModulePath }}/internal/version.Date={{.Date}}
+  - -X {{ .ModulePath }}/internal/version.GoVersion={{.GoVersion}}
   goos:
   - linux
   - darwin

cmd/delete_lab.go

@@ -31,7 +31,7 @@ func NewDeleteLabCmd() *cobra.Command {
 			}
 			// Delete the lab using lab manager
 			if err := labSvc.Delete(labName, skipTimeCheck); err != nil {
-				return fmt.Errorf("failed to delete lab: %w", err)
+				return fmt.Errorf("error deleting lab: %w", err)
 			}
 
 			fmt.Printf("Successfully deleted lab %s\n", labName)

cmd/get_key.go

@@ -27,6 +27,10 @@ func NewGetKeyCmd() *cobra.Command {
 }
 
 func listKeys() error {
+	err := initProvider(useProvider)
+	if err != nil {
+		return err
+	}
 	keys, err := providerSvc.AllSSHKeys()
 	if err != nil {
 		return err
@@ -55,6 +59,10 @@ func listKeys() error {
 }
 
 func getKey(name string) error {
+	err := initProvider(useProvider)
+	if err != nil {
+		return err
+	}
 	key, err := providerSvc.GetSSHKey(name)
 	if err != nil {
 		return err

cmd/get_lab.go

@@ -84,8 +84,10 @@ func getLab(labName string) error {
 	if err != nil {
 		return err
 	}
-	initLabManager()
-	fmt.Printf("Getting details for lab: %s\n", labName)
+	err = initLabManager()
+	if err != nil {
+		return err
+	}
 	lab, err := labSvc.Get(labName)
 	if err != nil {
 		return err

cmd/get_server.go

@@ -29,6 +29,10 @@ func NewGetServerCmd() *cobra.Command {
 }
 
 func listServers() error {
+	err := initProvider(useProvider)
+	if err != nil {
+		return err
+	}
 	servers, err := providerSvc.AllServers()
 	if err != nil {
 		return err
@@ -52,6 +56,10 @@ func listServers() error {
 }
 
 func getServer(serverID string) error {
+	err := initProvider(useProvider)
+	if err != nil {
+		return err
+	}
 	server, err := providerSvc.GetServer(serverID)
 	if err != nil {
 		return err

cmd/get_volume.go

@@ -29,6 +29,10 @@ func NewGetVolumeCmd() *cobra.Command {
 }
 
 func listVolumes() error {
+	err := initProvider(useProvider)
+	if err != nil {
+		return err
+	}
 	volumes, err := providerSvc.AllVolumes()
 	if err != nil {
 		return err
@@ -53,6 +57,10 @@ func listVolumes() error {
 }
 
 func getVolume(volumeID string) error {
+	err := initProvider(useProvider)
+	if err != nil {
+		return err
+	}
 	volume, err := providerSvc.GetVolume(volumeID)
 	if err != nil {
 		return err

cmd/root.go

@@ -64,6 +64,7 @@ func NewRootCmd() *cobra.Command {
 		NewConfigCmd(),
 		NewCreateCmd(),
 		NewSyncCmd(),
+		NewVersionCmd(),
 	)
 
 	return cmd

cmd/version.go

@@ -0,0 +1,23 @@
+package cmd
+
+import (
+	"fmt"
+	"runtime"
+
+	"github.com/pavelanni/storctl/internal/version"
+	"github.com/spf13/cobra"
+)
+
+func NewVersionCmd() *cobra.Command {
+	return &cobra.Command{
+		Use:   "version",
+		Short: "Print version information",
+		Run: func(cmd *cobra.Command, args []string) {
+			fmt.Printf("Version: %s\n", version.Version)
+			fmt.Printf("Commit: %s\n", version.Commit)
+			fmt.Printf("Build Date: %s\n", version.Date)
+			fmt.Printf("Go Version: %s\n", version.GoVersion)
+			fmt.Printf("OS/Arch: %s/%s\n", runtime.GOOS, runtime.GOARCH)
+		},
+	}
+}

docs/adr/0010-using-limactl.md

@@ -0,0 +1,47 @@
+# Using limactl
+
+## Status
+
+Accepted
+
+## Date
+
+2024-01-29
+
+## Context
+
+- Need to work with virtual machines on a macOS or Linux host
+- Lima is a tool of choice on macOS and also available on Linux
+- Lima can use QEMU as a backend virtualization engine
+- Lima is written in Go
+- There is an option to use Lima's Go library or use the CLI tool `limactl` from inside our Go code
+- There is also Colima that is a wrapper for Lima but it uses Docker instead of `containerd` as a containerization engine
+
+## Decision
+
+Use `limactl` CLI calls from inside Go code.
+
+1. The Go library used by Lima developers is not created for external consumption.
+   To use it we would have to go deep into its ecosystem and import a lot of other dependencies.
+
+2. The CLI interface is more stable so we are more safe in this case.
+
+3. In our case, performance is not a significant factor, so there is not much gain in using the native Go library.
+
+## Consequences
+
+### Positive
+
+- More stable interface
+- Fewer imports/dependencies
+
+### Negative
+
+- Need to parse the command JSON output
+- Slightly lower performance (but not visible by the end user)
+
+## Related Decisions
+
+
+## Notes
+

internal/lab/lab.go

@@ -316,8 +316,6 @@ func (m *ManagerSvc) createLabLima(lab *types.Lab) error {
 			Format: false,
 		})
 	}
-	// DEBUG
-	fmt.Printf("Additional disks: %v\n", additionalDisks)
 	specServers := lab.Spec.Servers
 	for _, serverSpec := range specServers {
 		s := &types.Server{

internal/provider/lima/server.go

@@ -299,7 +299,7 @@ func createVM(ctx context.Context, name, configPath string) error {
 		if ctx.Err() == context.DeadlineExceeded {
 			return fmt.Errorf("timeout while creating VM: %w", err)
 		}
-		return fmt.Errorf("creating VM: %w", err)
+		return fmt.Errorf("error creating VM: %w", err)
 	}
 
 	fmt.Printf("Successfully created VM %s\n", name)

internal/version/version.go

@@ -0,0 +1,8 @@
+package version
+
+var (
+	Version   = "dev"
+	Commit    = "none"
+	Date      = "unknown"
+	GoVersion = "unknown"
+)