Introduce WithMinPasswordLen configuration option #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlo-v-chernykh
force-pushed
the
introduce-min-password-len-configuration-option
branch
from
b5d5377 to
b43ee3d
Compare
pavlo-v-chernykh
force-pushed
the
introduce-min-password-len-configuration-option
branch
from
b43ee3d to
a25022c
Compare
pavlo-v-chernykh
deleted the
introduce-min-password-len-configuration-option
branch
SgtCoDFish
added a commit
to SgtCoDFish/cert-manager
that referenced
this pull request
Oct 28, 2021
Following the release of cert-manager v1.6.0, it was observed that an update to the keystore-go library was backwards-incompatible; it introduced a 6-character minimum length on passwords which wasn't previously in force. This led to pavlo-v-chernykh/keystore-go#30 which in turn led to pavlo-v-chernykh/keystore-go#31 This commit bumps to use the new version, which by default doesn't have a min password length Signed-off-by: Ashley Davis <[email protected]>
SgtCoDFish
added a commit
to SgtCoDFish/cert-manager
that referenced
this pull request
Oct 28, 2021
Following the release of cert-manager v1.6.0, it was observed that an update to the keystore-go library was backwards-incompatible; it introduced a 6-character minimum length on passwords which wasn't previously in force. This led to pavlo-v-chernykh/keystore-go#30 which in turn led to pavlo-v-chernykh/keystore-go#31 This commit bumps to use the new version, which by default doesn't have a min password length Signed-off-by: Ashley Davis <[email protected]>
jetstack-bot
pushed a commit
to jetstack-bot/cert-manager
that referenced
this pull request
Oct 28, 2021
Following the release of cert-manager v1.6.0, it was observed that an update to the keystore-go library was backwards-incompatible; it introduced a 6-character minimum length on passwords which wasn't previously in force. This led to pavlo-v-chernykh/keystore-go#30 which in turn led to pavlo-v-chernykh/keystore-go#31 This commit bumps to use the new version, which by default doesn't have a min password length Signed-off-by: Ashley Davis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hardcoded
minPasswordLenAdd
WithMinPasswordLenconfig optionSee #30 for details