y_ini - name[] parameter contains an empty string for single character keys

[spacemud]

I'm trying to loop through the keys of an INI file using the name[] parameter. For keys of a single character the parameter contains an empty string instead of the key. Interestingly, reading the key using INI_String works fine.

name:  value: test
name:  value: test
name:  value: test
name: ab value: test
name: bc value: test
name: cd value: test
a: test
ab: test

Code used:

#include <YSI\y_ini>

new
    gA[8],
    gAB[8];

main()
{
    INI_Load("test.ini");

    printf("a: %s", gA);
    printf("ab: %s", gAB);

    return 1;
}

INI:test[](name[], value[])
{
    printf("name: %s value: %s", name, value);

    INI_String("a", gA);
    INI_String("ab", gAB);

    return 1;
}

.ini file:

a=test
b=test
c=test
ab=test
bc=test
cd=test

[Y-Less]

I thought I already replied to this, apparently not...

INI_String uses strcmp internally, which returns 0 when one string is empty*, so I suspect if you use different values in your test file, not just "test" everywhere, you will see that it actually doesn't work correctly.

As for why name is empty, I don't know, but thanks.

* Some people call this a bug, I'm not certain as it is well documented behaviour, just not what they expect by just thinking that all the function does is check if two strings are the same, which is not all it does, but anyway...

[Misiur]

Looking into it

[Misiur]

#225

[Misiur]

I screwed up this one, this catches key names including padding before the =. I reverted the commit, and I'll look again how to make it work as intended

[Y-Less]

I fixed this. However, it is with a load of other commits, so I can't push just yet until the code all compiles correctly. For reference:

 YSI_Storage/y_ini/reading.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/YSI_Storage/y_ini/reading.inc b/YSI_Storage/y_ini/reading.inc
index b8260cd..6180a03 100644
--- a/YSI_Storage/y_ini/reading.inc
+++ b/YSI_Storage/y_ini/reading.inc
@@ -470,6 +470,8 @@ stock e_INI_LINE_TYPE:
 		case '=': return e_INI_LINE_TYPE_INVALID;
 		default: p0s = pos - 1;
 	}
+	// Default end point, for single-character lines.
+	end = pos;
 //state_in_entry: // Default (fall-through).
 	// Get the key.
 	for ( ; ; )

[Y-Less]

I don't know if single character tags were a problem, but maybe, and this should do them as well.

[Y-Less]

Actually, no it won't, but I think they worked anyway looking at the code.