Skip to content

Commit

Permalink
Pes 1073 digest channel test (#26)
Browse files Browse the repository at this point in the history
* removing links from digest_notification template

* removing app.event that monitors digestion channel

* version bump

* second attempt to comment out unwanted links

* version bump
  • Loading branch information
jlschlepp authored Oct 9, 2024
1 parent cb59563 commit b290ac0
Show file tree
Hide file tree
Showing 3 changed files with 57 additions and 57 deletions.
58 changes: 29 additions & 29 deletions backend/bot/templates/incident/digest_notification.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,35 +78,35 @@ def create(
),
"action_id": "incident.join_incident_channel",
},
""" {
"type": "button",
"text": {
"type": "plain_text",
"text": "Conference",
},
"url": conference_bridge,
"action_id": "incident.click_conference_bridge_link",
},
{
"type": "button",
"text": {
"type": "plain_text",
"text": "Incident Guide",
},
"url": config.active.links.get("incident_guide"),
"action_id": "incident.incident_guide_link",
},
{
"type": "button",
"text": {
"type": "plain_text",
"text": "Incident Postmortems",
},
"url": config.active.links.get(
"incident_postmortems"
),
"action_id": "incident.incident_postmortem_link",
}, """
# {
# "type": "button",
# "text": {
# "type": "plain_text",
# "text": "Conference",
# },
# "url": conference_bridge,
# "action_id": "incident.click_conference_bridge_link",
# },
# {
# "type": "button",
# "text": {
# "type": "plain_text",
# "text": "Incident Guide",
# },
# "url": config.active.links.get("incident_guide"),
# "action_id": "incident.incident_guide_link",
# },
# {
# "type": "button",
# "text": {
# "type": "plain_text",
# "text": "Incident Postmortems",
# },
# "url": config.active.links.get(
# "incident_postmortems"
# ),
# "action_id": "incident.incident_postmortem_link",
# },
],
},
],
Expand Down
54 changes: 27 additions & 27 deletions backend/tests/test_incident.py
Original file line number Diff line number Diff line change
Expand Up @@ -218,33 +218,33 @@ def test_incident_build_digest_notification(self):
"url": "https://test.slack.com/archives/mock",
"action_id": "incident.join_incident_channel",
},
{
"type": "button",
"text": {
"type": "plain_text",
"text": "Conference",
},
"url": "mock",
"action_id": "incident.click_conference_bridge_link",
},
{
"type": "button",
"text": {
"type": "plain_text",
"text": "Incident Guide",
},
"url": "https://changeme.com",
"action_id": "incident.incident_guide_link",
},
{
"type": "button",
"text": {
"type": "plain_text",
"text": "Incident Postmortems",
},
"url": "https://changeme.com",
"action_id": "incident.incident_postmortem_link",
},
# {
# "type": "button",
# "text": {
# "type": "plain_text",
# "text": "Conference",
# },
# "url": "mock",
# "action_id": "incident.click_conference_bridge_link",
# },
# {
# "type": "button",
# "text": {
# "type": "plain_text",
# "text": "Incident Guide",
# },
# "url": "https://changeme.com",
# "action_id": "incident.incident_guide_link",
# },
# {
# "type": "button",
# "text": {
# "type": "plain_text",
# "text": "Incident Postmortems",
# },
# "url": "https://changeme.com",
# "action_id": "incident.incident_postmortem_link",
# },
],
},
],
Expand Down
2 changes: 1 addition & 1 deletion version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v1.18
v1.19

0 comments on commit b290ac0

Please sign in to comment.