Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pes-1073 reverting changes from previous PR #24

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

jlschlepp
Copy link

@jlschlepp jlschlepp commented Oct 8, 2024

pes-1073 reverting changes from previous PR

Compliance Checklist

  • I have verified that this is not a new project. If it is a new project (new service, new application, new repository), I have submitted a ticket to InfoSec to review the new project and gained approval.

  • I have verified that the backout plan for this change conforms to our standard engineering backout plan located here. If it does not, I have documented an alternative backout plan below:

  • I have verified that this change is backwards compatible. If it is not, I have specified the breaking changes and how they will be handled below:

  • I have verified that this change will not impact the security controls built into the application or introduce any new security vulnerabilities. If it will, I have defined the security impact below:

  • I have verified that this change will not result in downtime. If it will, I have noted the impact below:

  • I have verified that no new dependencies were introduced. If they were, I have vetted them below:

  • I have verified that all applicable tests were updated to ensure complete test coverage of any new or modified code.

  • I have verified that any relevant documentation such as the README is still up to date and not impacted by my changes. If documentation needs updating for accuracy, I have done so.

@jlschlepp jlschlepp merged commit ce0f78d into main Oct 8, 2024
2 of 4 checks passed
@jlschlepp jlschlepp deleted the pes-1073_rollback_recentchanges branch October 8, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants