Prepare Payjoin PSBT with no output keypaths #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like something that should be checked in the integration tests. |
This is a verbatim check the sender does. This change prepares the Payjoin PSBT from the receiver to satisfy that check.
Don't construct BTreeMap::new(), just use .clear() to same effect
Both input and output keypath information is supposed to be removed according to bip78. Include them during construction so that our library removes them and thaht removal does not regress. See: https://github.com/bitcoin/bips/blob/master/bip-0078.mediawiki#senders-payjoin-proposal-checklist
|
Good point. I made bitcoind add bip32derivs (keypaths) in integration tests to check that they're properly cleared. If you cherry-pick 69e2fa1 onto master you can see that it fails without the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BIP78 sender checklist "Verif[ies] that no keypaths is in the PSBT output," and this check was failing with our receiver.
This change ensures that check is satisfied.
https://github.com/bitcoin/bips/blob/master/bip-0078.mediawiki#user-content-Senders_payjoin_proposal_checklist