Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Async keyword from PayPalNativeCheckoutClient.start function and fix tests #212

Merged
merged 9 commits into from
Oct 26, 2023
Merged

Remove Async keyword from PayPalNativeCheckoutClient.start function and fix tests #212

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
439f4d6
Remove async await from PayPalNativeCheckoutClient.start and fix tests
KunJeongPark Oct 23, 2023
69b69b7
deprecate async native checkout start func
KunJeongPark Oct 23, 2023
292595c
fix tests with new function name
KunJeongPark Oct 23, 2023
51d1f1b
CHANGELOG for deprecating async start
KunJeongPark Oct 23, 2023
fb36b83
README for native checkout
KunJeongPark Oct 23, 2023
0894b93
revert all commits to first
KunJeongPark Oct 25, 2023
d13c53e
add comment to remove async start on NativeCheckoutClient next major …
KunJeongPark Oct 25, 2023
f899d28
linting error
KunJeongPark Oct 25, 2023
dd91cff
move next_major_version comment up
KunJeongPark Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/PayPalNativePayments/PayPalNativeCheckoutClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ public class PayPalNativeCheckoutClient {
self.networkingClient = networkingClient
}

// NEXT_MAJOR_VERSION: - Change to non-async
/// Present PayPal Paysheet and start a PayPal transaction
/// - Parameters:
/// - request: The PayPalNativeCheckoutRequest for the transaction
Expand Down
Loading