Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merchant Passed Email for Native Checkout, Update PayPalCheckout to 1.2.0 #213

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

mariolopez-pypl
Copy link
Contributor

@mariolopez-pypl mariolopez-pypl commented Oct 24, 2023

Reason for changes

Allows a Merchant to pass a user email to initiate a quicker authentication flow in cases where the user has a PayPal Account with the same email. And Update PayPalCheckout from 1.1.0 to 1.2.0

Summary of changes

Added a new parameter to PayPalNativeCheckoutRequest to handle the user email the merchant passes and modified the MockNativeCheckoutProvider so we can check if the email get passed in correct through the request

Checklist

  • Added a changelog entry

@mariolopez-pypl mariolopez-pypl requested a review from a team as a code owner October 24, 2023 19:17
@mariolopez-pypl mariolopez-pypl changed the title Merchant Passed Email for Native Checkout Merchant Passed Email for Native Checkout, Update PayPalCheckout to 1.2.0 Nov 14, 2023
@scannillo
Copy link
Collaborator

👋 These changes look good to me! There are some SwiftLint checks that failed.

The SPM build failures is related to the fact that this PR was open on a fork. So for now we can ignore that one, until we update our CI to support building for fork branches.

@mariolopez-pypl
Copy link
Contributor Author

Hey @scannillo, I just updated and fixed the SwiftLint issues!

@KunJeongPark
Copy link
Collaborator

🎉 Great job!

@scannillo scannillo merged commit a226c92 into paypal:main Nov 14, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants