Vault with Purchase PayPalWeb #221

KunJeongPark · 2023-11-16T22:21:21Z

Summary of changes

Created UI for vault option for PayPalWeb checkout in demo app
Added experience_context and vault parameters with vault option selected in create order
Display vaultID and customerID in capture/authorize if PayPal payment is vaulted with checkout

vaultPurchasePP3.mp4

Checklist

~~- [ ] Added a changelog entry~~

Authors

@KunJeongPark

KunJeongPark · 2023-11-20T17:30:26Z

Demo/Demo/ViewModels/PayPalWebViewModel.swift

+                    storeInVault: "ON_SUCCESS",
+                    usageType: "MERCHANT",
+                    customerType: "CONSUMER"
+                ),


Just hard coded this for direct merchant but I am investigating what different parameters are for different selected merchant integrations.

We should get input from product on what we need to support here for v1 in the demo app.

-Victoria : yes, Walter referenced docs during stand and I plan on working with Nirvan and Walter on the specs.

So right now, in demo app we only have direct, connected and managed path configured, not specific paths like CP2 or CP4. The usageType would depend on specific integration patterns.

I think specs for server side inputs like auth headers and payee info should be made for each integration types in another PR.

yes, Walter referenced docs during stand and I plan on working with Nirvan and Walter on the specs.

So right now, in demo app we only have direct, connected and managed path configured, not specific paths like CP2 or CP4. The usageType would depend on specific integration patterns.

I think specs for server side inputs like auth headers and payee info should be made for each integration types in another PR.

jaxdesmarais · 2023-11-21T14:28:04Z

Demo/Demo/Models/CreateOrderParams.swift

@@ -30,15 +62,17 @@ struct VaultCard: Encodable {
 struct Attributes: Encodable {

    let vault: Vault
-    let customer: CardVaultCustomer?
+    let customer: VaultCustomer?


I wonder if we can just call this Customer instead of VaultCustomer.

Addressed here: 62480f6

jaxdesmarais · 2023-11-21T14:29:23Z

Demo/Demo/SwiftUIComponents/PayPalWebViews/CreateOrderPayPalWebView.swift

@@ -5,6 +5,8 @@ struct CreateOrderPayPalWebView: View {
    @ObservedObject var paypalWebViewModel: PayPalWebViewModel

    @State private var selectedIntent: Intent = .authorize
+    @State private var vaultCustomerID: String = ""


I thought you had said during stand that regardless of what's customer ID is passed in the API always generates one? If that's the case, I think we should remove this from our demo.

Yes, my plan is to do that today.

Addressed in commit dc0c32e and f07d0bc

jaxdesmarais · 2023-11-21T14:31:04Z

Demo/Demo/SwiftUIComponents/PayPalWebViews/PayPalWebOrderCompletionResultView.swift

+            if let vaultID = orderResponse.paymentSource?.paypal?.attributes?.vault.id {
+                LeadingText("Vault ID / Payment Token", weight: .bold)
+                LeadingText("\(vaultID)")
+            }


General question: is there an agreed upon name that JS calls this in our public docs? I see we use both vault ID and payment token here. We should use whichever name is used in our public docs.

I think for the customer point of view, we call it payment token , but we reference it as vault ID in the APIs.
I just referenced vault Id on the label to clarify that they are the same.

jaxdesmarais · 2023-11-21T14:32:25Z

Demo/Demo/ViewModels/PayPalWebViewModel.swift

+                    storeInVault: "ON_SUCCESS",
+                    usageType: "MERCHANT",
+                    customerType: "CONSUMER"
+                ),


We should get input from product on what we need to support here for v1 in the demo app.

-Victoria : yes, Walter referenced docs during stand and I plan on working with Nirvan and Walter on the specs.

So right now, in demo app we only have direct, connected and managed path configured, not specific paths like CP2 or CP4. The usageType would depend on specific integration patterns.

I think specs for server side inputs like auth headers and payee info should be made for each integration types in another PR.

KunJeongPark · 2023-11-27T17:05:08Z

62480f6 commit message should have been "reuse for Vault customer encoding"

scannillo · 2023-11-28T20:52:17Z

Demo/Demo/Models/CreateOrderParams.swift

@@ -3,7 +3,7 @@ struct CreateOrderParams: Encodable {
    let applicationContext: ApplicationContext?
    let intent: String
    var purchaseUnits: [PurchaseUnit]?
-    var paymentSource: VaultCardPaymentSource?
+    var paymentSource: VaultPaymentSource?


Just to clarify my understanding - a merchant only needs to set the paymentSource in their create order call if they want to vault, correct?

How do we document this to a merchant?

Yes, JS SDK has documentation on this on their developer site. We should do something similar.

scannillo · 2023-11-28T20:52:36Z

Demo/Demo/SwiftUIComponents/PayPalWebViews/CreateOrderPayPalWebView.swift

@@ -22,6 +23,10 @@ struct CreateOrderPayPalWebView: View {
                Text("CAPTURE").tag(Intent.capture)
            }
            .pickerStyle(SegmentedPickerStyle())
+            HStack {
+                Toggle("Should Vault with Purchase", isOn: $shouldVaultSelected)


This looks great!

scannillo · 2023-11-28T20:55:20Z

Demo/Demo/ViewModels/PayPalWebViewModel.swift

+                    customerType: "CONSUMER"
+                )
+            )
+            let paypal = VaultPayPal(attributes: attributes, experienceContext: ExperienceContext(returnURL: "https://example.com/returnUrl", cancelURL: "https://example.com/cancelUrl"))


In your video, the redirect back to the Demo app looked fine, even though you would think the experienceContext should be a URL scheme to the app. What happens if the merchant doesn't set these URLs?

The endpoint throws an error without the experienceContext field for PayPal vaulting.

In our SDK, when we launch the ASWebSession for PayPalWeb, we construct the redirectURLString and append it as a query parameter to the checkout url :

paypal-ios/Sources/PayPalWebPayments/PayPalWebCheckoutClient.swift

Line 86 in 29307de

func payPalCheckoutReturnURL(payPalCheckoutURL: URL) -> URL? {

The redirect url is included as a parameter in the url that we construct to launch the webSession.
I don't know if this is a typo or intentional but query parameter name for redirect url is strange.

So this experienceContext in create Order API is only relevant to JS SDK but the API fails nonetheless
without it.

:sigh: That's right, this is an issue with the create-order API. It doesn't accept non-https URLs.

We should add a comment to make this issue clear in the code. That basically createOrder requires an https URL, which doesn't get used by the SDK flow at all. The merchant could put https://bogus.com and things will work fine.

Yes. That might be an actual site.

Added comments above to clarify that required experienceContext fields for PayPal vault with purchase are not used in the SDK.

I don't suppose there is a way for use to pass a URL on our merchants behalf so they don't need to do this step?

The createOrder will just error if that URL value isn't set or is an empty string. It also errors if the string doesn't start with https. Victoria - can we make a JIRA for tracking taking up this issue with the API team?

Created - DTPPCPSDK-1492

…in order create not used in SDK

jaxdesmarais · 2023-11-30T15:20:50Z

Demo/Demo/ViewModels/CardPaymentViewModel.swift

            }
-            let attributes = Attributes(vault: Vault(storeInVault: "ON_SUCCESS"), customer: customer)
+            let attributes = Attributes(vault: Vault(storeInVault: "ON_SUCCESS", usageType: nil, customerType: nil), customer: customer)


Can we default usageType and customerType to nil in the struct?

addressed here: c77464c

jaxdesmarais · 2023-11-30T15:22:02Z

Demo/Demo/ViewModels/PayPalWebViewModel.swift

+            let attributes = Attributes(
+                vault: Vault(
+                    storeInVault: "ON_SUCCESS",
+                    usageType: "MERCHANT",
+                    customerType: "CONSUMER"
+                )
+            )


nit: if we single line this are we still under our linter warning?

I'll try it. No warning and it's much more readable.

addressed here: c77464c

jaxdesmarais · 2023-11-30T15:24:11Z

Demo/Demo/ViewModels/PayPalWebViewModel.swift

+                    customerType: "CONSUMER"
+                )
+            )
+            let paypal = VaultPayPal(attributes: attributes, experienceContext: ExperienceContext(returnURL: "https://example.com/returnUrl", cancelURL: "https://example.com/cancelUrl"))


I don't suppose there is a way for use to pass a URL on our merchants behalf so they don't need to do this step?

scannillo · 2023-11-30T17:58:12Z

Demo/Demo/ViewModels/PayPalWebViewModel.swift

+                    customerType: "CONSUMER"
+                )
+            )
+            // The returnURL is not used in our mobile SDK, but a required field for create order with PayPal payment source.


Nitpick - I would also add a reference to the JIRA ticket # that summarizes this issue we need to take up with the API team!

addressed here: c77464c

vault with purchase create order PayPal

11da801

KunJeongPark changed the title ~~vault with purchase create order PayPal~~ Vault with Purchase PayPalWeb Nov 16, 2023

remove unnecessary decoding of links field

e7abc8e

KunJeongPark commented Nov 20, 2023

View reviewed changes

KunJeongPark marked this pull request as ready for review November 20, 2023 18:25

KunJeongPark requested a review from a team as a code owner November 20, 2023 18:25

jaxdesmarais reviewed Nov 21, 2023

View reviewed changes

KunJeongPark added 3 commits November 27, 2023 08:19

remove customerID entry for PP vault with purchase

dc0c32e

add initializer with default nil for customer

f07d0bc

change Customer to Codable for reuse for Vault customer decoding

62480f6

scannillo reviewed Nov 28, 2023

View reviewed changes

Add comments that required experienceContext for PayPal vault option …

52a662f

…in order create not used in SDK

jaxdesmarais reviewed Nov 30, 2023

View reviewed changes

scannillo reviewed Nov 30, 2023

View reviewed changes

scannillo approved these changes Nov 30, 2023

View reviewed changes

Jax, Sammy PR feedback

c77464c

jaxdesmarais approved these changes Nov 30, 2023

View reviewed changes

KunJeongPark merged commit ae1adc3 into main Nov 30, 2023
4 checks passed

KunJeongPark deleted the vaultwithPurchasePayPal branch November 30, 2023 21:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vault with Purchase PayPalWeb #221

Vault with Purchase PayPalWeb #221

KunJeongPark commented Nov 16, 2023 •

edited

Loading

KunJeongPark Nov 20, 2023 •

edited

Loading

jaxdesmarais Nov 21, 2023 •

edited by KunJeongPark

Loading

KunJeongPark Nov 27, 2023

KunJeongPark Nov 27, 2023

jaxdesmarais Nov 21, 2023

KunJeongPark Nov 27, 2023

jaxdesmarais Nov 21, 2023

KunJeongPark Nov 27, 2023

KunJeongPark Nov 27, 2023 •

edited

Loading

jaxdesmarais Nov 21, 2023

KunJeongPark Nov 27, 2023

jaxdesmarais Nov 21, 2023 •

edited by KunJeongPark

Loading

KunJeongPark commented Nov 27, 2023

scannillo Nov 28, 2023

KunJeongPark Nov 29, 2023

scannillo Nov 28, 2023

scannillo Nov 28, 2023

KunJeongPark Nov 29, 2023 •

edited

Loading

KunJeongPark Nov 29, 2023 •

edited

Loading

scannillo Nov 29, 2023

KunJeongPark Nov 29, 2023

KunJeongPark Nov 29, 2023

jaxdesmarais Nov 30, 2023

scannillo Nov 30, 2023

KunJeongPark Nov 30, 2023

KunJeongPark Nov 30, 2023

jaxdesmarais Nov 30, 2023

KunJeongPark Nov 30, 2023

jaxdesmarais Nov 30, 2023

KunJeongPark Nov 30, 2023 •

edited

Loading

KunJeongPark Nov 30, 2023

jaxdesmarais Nov 30, 2023

scannillo Nov 30, 2023

KunJeongPark Nov 30, 2023

Vault with Purchase PayPalWeb #221

Vault with Purchase PayPalWeb #221

Conversation

KunJeongPark commented Nov 16, 2023 • edited Loading

Summary of changes

Checklist

Authors

KunJeongPark Nov 20, 2023 • edited Loading

Choose a reason for hiding this comment

jaxdesmarais Nov 21, 2023 • edited by KunJeongPark Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KunJeongPark Nov 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaxdesmarais Nov 21, 2023 • edited by KunJeongPark Loading

Choose a reason for hiding this comment

KunJeongPark commented Nov 27, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KunJeongPark Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

KunJeongPark Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KunJeongPark Nov 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KunJeongPark commented Nov 16, 2023 •

edited

Loading

KunJeongPark Nov 20, 2023 •

edited

Loading

jaxdesmarais Nov 21, 2023 •

edited by KunJeongPark

Loading

KunJeongPark Nov 27, 2023 •

edited

Loading

jaxdesmarais Nov 21, 2023 •

edited by KunJeongPark

Loading

KunJeongPark Nov 29, 2023 •

edited

Loading

KunJeongPark Nov 29, 2023 •

edited

Loading

KunJeongPark Nov 30, 2023 •

edited

Loading