Fix formatting (#552)

* remove prettier for packages/paypal-js * uninstall prettier for packages/react-paypal-js * update prettier version to 3.1.1 in root level * remove format and format:check * remove format:check from validate * change format, update node version to v18, fixed build errors * run changeset add --empty * update prettier version from 3.1.1 to 3.3.3 * remove .nvmrc and lint-staged.config.js in react-paypal-js * fix package-lock registry value for prettier * fix changesets + prettier --------- Co-authored-by: Hai-Yen Nguyen <[email protected]> Co-authored-by: Shane Brunson <[email protected]>
paypal · Aug 9, 2024 · 638e8e6 · 638e8e6
1 parent f96c7f6
commit 638e8e6
Show file tree

Hide file tree

Showing 90 changed files with 608 additions and 1,468 deletions.
diff --git a/.changeset/silver-trees-give.md b/.changeset/silver-trees-give.md
@@ -0,0 +1,6 @@
+---
+"@paypal/react-paypal-js": patch
+"@paypal/paypal-js": patch
+---
+
+remove .nvmrc and lint-staged.config.js in react-paypal-js
diff --git a/.changeset/slow-plums-refuse.md b/.changeset/slow-plums-refuse.md
@@ -0,0 +1,6 @@
+---
+"@paypal/react-paypal-js": patch
+"@paypal/paypal-js": patch
+---
+
+remove the prettier dependency from each packages, update the prettier root version, fixed build error, update note version to 18
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -29,9 +29,9 @@
         ]
     },
     "devDependencies": {
-        "@changesets/cli": "^2.25.2",
+        "@changesets/cli": "^2.27.7",
         "husky": "^8.0.1",
         "lint-staged": "^13.0.3",
-        "prettier": "^2.7.1"
+        "prettier": "^3.3.3"
     }
 }
diff --git a/packages/paypal-js/README.md b/packages/paypal-js/README.md
@@ -229,7 +229,7 @@ We also provide a legacy build that includes the [promise-polyfill](https://gith
 The paypal-js script is also available on the [unpkg CDN](https://unpkg.com/). The iife/paypal-js.js build assigns the `loadScript` function to the window object as `window.paypalLoadScript`. Here's an example:
 
 ```html
-<!DOCTYPE html>
+<!doctype html>
 <html lang="en">
     <head>
         <script src="https://unpkg.com/@paypal/[email protected]/dist/iife/paypal-js.min.js"></script>

diff --git a/packages/paypal-js/bundle-tests/bundle-size.test.js b/packages/paypal-js/bundle-tests/bundle-size.test.js
@@ -15,7 +15,7 @@ describe("bundle size", () => {
 
     test(`paypal-js.legacy.min.js should be less than ${maxLegacyBundleSizeInKiloBytes} KB`, () => {
         const { size: sizeInBytes } = fs.statSync(
-            "dist/iife/paypal-js.legacy.min.js"
+            "dist/iife/paypal-js.legacy.min.js",
         );
         const [sizeInKiloBytes] = filesize(sizeInBytes, { output: "array" });
 

diff --git a/packages/paypal-js/e2e-tests/browser-global.html b/packages/paypal-js/e2e-tests/browser-global.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
     <head>
         <meta charset="UTF-8" />

diff --git a/packages/paypal-js/e2e-tests/browser-global.test.ts b/packages/paypal-js/e2e-tests/browser-global.test.ts
@@ -6,17 +6,17 @@ test("Browser global window.paypalLoadScript", async ({ page }) => {
         route.fulfill({
             status: 200,
             body: successfulSDKResponseMock(),
-        })
+        }),
     );
 
     await page.goto("/e2e-tests/browser-global.html");
 
     await expect(page).toHaveTitle(
-        "Demo with window.paypalLoadScript | PayPal JS"
+        "Demo with window.paypalLoadScript | PayPal JS",
     );
 
     const scriptElement = await page.locator(
-        'script[src^="https://www.paypal.com/sdk/js"]'
+        'script[src^="https://www.paypal.com/sdk/js"]',
     );
     const uidFromDOM = await scriptElement.getAttribute("data-uid-auto");
 

diff --git a/packages/paypal-js/e2e-tests/http-server.js b/packages/paypal-js/e2e-tests/http-server.js
@@ -48,7 +48,7 @@ http.createServer(function (request, response) {
                 response.end(
                     "Sorry, check with the site admin for error: " +
                         error.code +
-                        " ..\n"
+                        " ..\n",
                 );
             }
         } else {

diff --git a/packages/paypal-js/e2e-tests/load-cached-script.html b/packages/paypal-js/e2e-tests/load-cached-script.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
     <head>
         <meta charset="UTF-8" />

diff --git a/packages/paypal-js/e2e-tests/load-cached-script.test.ts b/packages/paypal-js/e2e-tests/load-cached-script.test.ts
@@ -6,7 +6,7 @@ test("Load cached script", async ({ page }) => {
         route.fulfill({
             status: 200,
             body: successfulSDKResponseMock(),
-        })
+        }),
     );
 
     let sdkRequestCounter = 0;

diff --git a/packages/paypal-js/e2e-tests/reload-script.html b/packages/paypal-js/e2e-tests/reload-script.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
     <head>
         <meta charset="UTF-8" />

diff --git a/packages/paypal-js/e2e-tests/validation-errors.html b/packages/paypal-js/e2e-tests/validation-errors.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
     <head>
         <meta charset="UTF-8" />

diff --git a/packages/paypal-js/e2e-tests/validation-errors.test.ts b/packages/paypal-js/e2e-tests/validation-errors.test.ts
@@ -6,23 +6,23 @@ test("Validation errors", async ({ page }) => {
         route.fulfill({
             status: 400,
             body: validationErrorSDKResponseMock(),
-        })
+        }),
     );
 
     await page.goto("/e2e-tests/validation-errors.html");
     await expect(page).toHaveTitle("Validation Errors | PayPal JS");
     await page.locator("#btn-load-no-client-id").click();
 
     await page.waitForResponse((response) =>
-        response.url().startsWith("https://www.paypal.com/sdk/js")
+        response.url().startsWith("https://www.paypal.com/sdk/js"),
     );
 
     await page.waitForFunction(
-        'document.querySelector("#error-message").innerText.length'
+        'document.querySelector("#error-message").innerText.length',
     );
 
     const errorMessage = await page.locator("#error-message").innerText();
     expect(errorMessage).toEqual(
-        'Error: The script "https://www.paypal.com/sdk/js?" failed to load. Check the HTTP status code and response body in DevTools to learn more.'
+        'Error: The script "https://www.paypal.com/sdk/js?" failed to load. Check the HTTP status code and response body in DevTools to learn more.',
     );
 });
diff --git a/packages/paypal-js/package.json b/packages/paypal-js/package.json
@@ -19,8 +19,8 @@
         "test:e2e": "playwright test",
         "test:e2e:debug": "PWDEBUG=1 playwright test --project=\"chromium\"",
         "test:e2e:start": "node e2e-tests/http-server.js",
-        "typecheck": "tsc --noEmit",
-        "validate": "npm run check-node-version && npm run format:check && npm run typecheck && npm run build && npm run lint && npm test -- --watch=false --coverage.enabled --coverage.include=src && npm run test:bundle -- --watch=false",
+        "typecheck": "tsc --noEmit --allowSyntheticDefaultImports",
+        "validate": "npm run check-node-version && npm run typecheck && npm run build && npm run lint && npm test -- --watch=false --coverage.enabled --coverage.include=src && npm run test:bundle -- --watch=false",
         "openapi": "npm run openapi-orders && npm run openapi-subscriptions",
         "openapi-orders": "openapi-typescript node_modules/@paypal/paypal-rest-api-specifications/openapi/checkout_orders_v2.json -o types/apis/openapi/checkout_orders_v2.d.ts",
         "openapi-subscriptions": "openapi-typescript node_modules/@paypal/paypal-rest-api-specifications/openapi/billing_subscriptions_v1.json -o types/apis/openapi/billing_subscriptions_v1.d.ts"
@@ -66,7 +66,6 @@
         "jsdom": "^23.0.1",
         "lint-staged": "15.2.0",
         "openapi-typescript": "^6.7.3",
-        "prettier": "3.1.1",
         "rollup": "4.9.1",
         "semver": "7.5.4",
         "standard-version": "9.5.0",

diff --git a/packages/paypal-js/src/legacy/index.ts b/packages/paypal-js/src/legacy/index.ts
@@ -1,4 +1,4 @@
-import Promise from "promise-polyfill";
+import * as Promise from "promise-polyfill";
 import {
     loadScript as originalLoadScript,
     loadCustomScript as originalLoadCustomScript,
@@ -7,7 +7,7 @@ import type { PayPalScriptOptions } from "../../types/script-options";
 import type { PayPalNamespace } from "../../types/index";
 
 export function loadScript(
-    options: PayPalScriptOptions
+    options: PayPalScriptOptions,
 ): Promise<PayPalNamespace | null> {
     return originalLoadScript(options, Promise);
 }

diff --git a/packages/paypal-js/src/load-script.node.test.ts b/packages/paypal-js/src/load-script.node.test.ts
@@ -7,6 +7,6 @@ import { loadScript, loadCustomScript } from "./load-script";
 test("should still resolve when global window object does not exist", async () => {
     await expect(loadScript({ clientId: "test" })).resolves.toBeNull();
     await expect(
-        loadCustomScript({ url: "https://www.example.com/index.js" })
+        loadCustomScript({ url: "https://www.example.com/index.js" }),
     ).resolves.toBeUndefined();
 });
diff --git a/packages/paypal-js/src/load-script.test.ts b/packages/paypal-js/src/load-script.test.ts
@@ -16,7 +16,7 @@ vi.mock("./utils", async () => {
                     const namespace = attributes["data-namespace"] || "paypal";
                     vi.stubGlobal(namespace, { version: "5" });
                     process.nextTick(() => onSuccess());
-                }
+                },
             ),
     };
 });
@@ -38,7 +38,7 @@ describe("loadScript()", () => {
 
         const response = await loadScript({ clientId: "test" });
         expect(mockedInsertScriptElement.mock.calls[0][0].url).toEqual(
-            "https://www.paypal.com/sdk/js?client-id=test"
+            "https://www.paypal.com/sdk/js?client-id=test",
         );
         expect(mockedInsertScriptElement).toHaveBeenCalledTimes(1);
         expect(response).toEqual(window.paypal);
@@ -53,7 +53,7 @@ describe("loadScript()", () => {
         });
         expect(mockedInsertScriptElement).toHaveBeenCalledTimes(1);
         expect(mockedInsertScriptElement.mock.calls[0][0].url).toEqual(
-            "https://www.sandbox.paypal.com/sdk/js?client-id=test"
+            "https://www.sandbox.paypal.com/sdk/js?client-id=test",
         );
         expect(response).toEqual(window.paypal);
     });
@@ -67,7 +67,7 @@ describe("loadScript()", () => {
         });
         expect(mockedInsertScriptElement).toHaveBeenCalledTimes(1);
         expect(mockedInsertScriptElement.mock.calls[0][0].url).toEqual(
-            "https://www.paypal.com/sdk/js?client-id=test"
+            "https://www.paypal.com/sdk/js?client-id=test",
         );
         expect(response).toEqual(window.paypal);
     });
@@ -117,7 +117,7 @@ describe("loadScript()", () => {
             const { message: errorMessage } = err as Record<string, string>;
 
             expect(errorMessage).toBe(
-                "The window.paypal global variable is not available."
+                "The window.paypal global variable is not available.",
             );
         }
     });
@@ -129,9 +129,9 @@ describe("loadScript()", () => {
                 clientId: "test",
                 // @ts-expect-error intentionally sending invalid value
                 environment: "invalid",
-            })
+            }),
         ).toThrowError(
-            'The `environment` option must be either "production" or "sandbox"'
+            'The `environment` option must be either "production" or "sandbox"',
         );
     });
 
@@ -140,7 +140,7 @@ describe("loadScript()", () => {
         expect(() => loadScript()).toThrow("Expected an options object.");
         // @ts-expect-error ignore invalid arguments error
         expect(() => loadScript({}, {})).toThrow(
-            "Expected PromisePonyfill to be a function."
+            "Expected PromisePonyfill to be a function.",
         );
     });
 });
@@ -163,7 +163,7 @@ describe("loadCustomScript()", () => {
 
         await loadCustomScript(options);
         expect(mockedInsertScriptElement).toHaveBeenCalledWith(
-            expect.objectContaining(options)
+            expect.objectContaining(options),
         );
     });
 
@@ -179,16 +179,16 @@ describe("loadCustomScript()", () => {
                 url: "https://www.example.com/index.js",
                 // @ts-expect-error ignore invalid arguments error
                 attributes: "",
-            })
+            }),
         ).toThrow("Expected attributes to be an object.");
         expect(() =>
             loadCustomScript(
                 {
                     url: "https://www.example.com/index.js",
                 },
                 // @ts-expect-error ignore invalid arguments error
-                {}
-            )
+                {},
+            ),
         ).toThrow("Expected PromisePonyfill to be a function.");
     });
 
@@ -209,7 +209,7 @@ describe("loadCustomScript()", () => {
             const { message } = err as Record<string, string>;
 
             expect(message).toBe(
-                'The script "https://www.example.com/index.js" failed to load. Check the HTTP status code and response body in DevTools to learn more.'
+                'The script "https://www.example.com/index.js" failed to load. Check the HTTP status code and response body in DevTools to learn more.',
             );
         }
     });
@@ -225,7 +225,7 @@ describe("loadCustomScript()", () => {
                 url: "https://www.example.com/index.js",
             },
             // @ts-expect-error ignore mock error
-            PromisePonyfill
+            PromisePonyfill,
         );
         expect(PromisePonyfill).toHaveBeenCalledTimes(1);
     });

diff --git a/packages/paypal-js/src/load-script.ts b/packages/paypal-js/src/load-script.ts
@@ -11,7 +11,7 @@ import type { PayPalNamespace } from "../types/index";
  */
 export function loadScript(
     options: PayPalScriptOptions,
-    PromisePonyfill: PromiseConstructor = Promise
+    PromisePonyfill: PromiseConstructor = Promise,
 ): Promise<PayPalNamespace | null> {
     validateArguments(options, PromisePonyfill);
 
@@ -36,7 +36,7 @@ export function loadScript(
             url,
             attributes: attributes,
         },
-        PromisePonyfill
+        PromisePonyfill,
     ).then(() => {
         const newWindowNamespace = getPayPalWindowNamespace(namespace);
 
@@ -45,7 +45,7 @@ export function loadScript(
         }
 
         throw new Error(
-            `The window.${namespace} global variable is not available.`
+            `The window.${namespace} global variable is not available.`,
         );
     });
 }
@@ -62,7 +62,7 @@ export function loadCustomScript(
         url: string;
         attributes?: Record<string, string>;
     },
-    PromisePonyfill: PromiseConstructor = Promise
+    PromisePonyfill: PromiseConstructor = Promise,
 ): Promise<void> {
     validateArguments(options, PromisePonyfill);
 
@@ -86,7 +86,7 @@ export function loadCustomScript(
             onSuccess: () => resolve(),
             onError: () => {
                 const defaultError = new Error(
-                    `The script "${url}" failed to load. Check the HTTP status code and response body in DevTools to learn more.`
+                    `The script "${url}" failed to load. Check the HTTP status code and response body in DevTools to learn more.`,
                 );
 
                 return reject(defaultError);
@@ -112,7 +112,7 @@ function validateArguments(options: unknown, PromisePonyfill?: unknown) {
         environment !== "sandbox"
     ) {
         throw new Error(
-            'The `environment` option must be either "production" or "sandbox".'
+            'The `environment` option must be either "production" or "sandbox".',
         );
     }