Skip to content

Commit

Permalink
RUN-3949 Fixed issue where no correlation errors were thrown when use…
Browse files Browse the repository at this point in the history
… d along side the legacy API. (HadoukenIO#96)

* RUN-3949 Fixed issue where no correlation errors were thrown when used along side the legacy API.

* RUN-3949 No correlation errors not needed
  • Loading branch information
rdepena authored Mar 19, 2018
1 parent 1e38ea2 commit 07e2fdf
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 0 additions & 2 deletions js-adapter/src/transport/transport-errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ export class DuplicateCorrelationError extends Error { }

export class NoAckError extends Error { }

export class NoCorrelationError extends Error { }

export class NotImplementedError extends Error { }

export class RuntimeError extends Error {
Expand Down
4 changes: 1 addition & 3 deletions js-adapter/src/transport/transport.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import {
UnexpectedActionError,
DuplicateCorrelationError,
NoAckError,
NoCorrelationError,
RuntimeError
} from './transport-errors';

Expand Down Expand Up @@ -165,8 +164,7 @@ class Transport extends EventEmitter {
// tslint:disable-next-line
this.uncorrelatedListener = () => { };
} else if (!(id in this.wireListeners)) {
throw new NoCorrelationError(String(id));
// Return false?
return false;
} else {
const { resolve, reject } = this.wireListeners[id];
if (data.action !== 'ack') {
Expand Down

0 comments on commit 07e2fdf

Please sign in to comment.