Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Credits Page #193 #203

Merged
merged 18 commits into from
Jan 26, 2025
Merged

Refactor Credits Page #193 #203

merged 18 commits into from
Jan 26, 2025

Conversation

Nexusrex18
Copy link
Contributor

@Nexusrex18 Nexusrex18 commented Jan 25, 2025

Fixes #193

Changes Made

  • Added functionality to fetch contributors directly from the GitHub Contributors API and enable CRUD operations on them.
  • Fixed the Safari browser preview issue.
  • Removed the Credit section from the landing page.
  • Integrated the Credit section as a card component displayed alongside the Blog and Mixtape sections.

Video preview

Screen.Recording.2025-01-25.171637.mp4

Comments:

webcont
@SkySingh04 bhaiya , this issue is most probably arising due to existing hydration error of website which i cant find out in my localhost preview and also on reloading the page again it fixes itself but im trying to find the solution for it but i will fix it as i find the solution.
2.
For syncing the github contributors api i need cron job but maine @2004yash se pucha tha to usne bataya ki production server ko github easily allow nhi krte data fetching ke liye but mai ye issue fix kr dunga baad me naya issue create krke tab tak weekly mjhe POST request manually run krni pdegi.

Copy link

@akashsinghvance akashsinghvance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nexusrex18 You dont need a cron job for syncing the contributors, it is a simple API call to the github api. You can call it everytime the page is loaded, with a loader

@Nexusrex18
Copy link
Contributor Author

@SkySingh04 but is pr ka kya kru bhaiya hatana hai ya naya pr daalu

@Nexusrex18
Copy link
Contributor Author

@SkySingh04 bhaiya thik kar diya wo ek baar check kar lena :D

Copy link
Member

@SkySingh04 SkySingh04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SkySingh04 SkySingh04 merged commit bd853dd into pbdsce:staging Jan 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants