Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character auto-removal for same char types doesn't work correctly #105

Closed
4 of 5 tasks
Waqar144 opened this issue Feb 18, 2020 · 2 comments
Closed
4 of 5 tasks

Character auto-removal for same char types doesn't work correctly #105

Waqar144 opened this issue Feb 18, 2020 · 2 comments
Labels

Comments

@Waqar144
Copy link
Contributor

Waqar144 commented Feb 18, 2020

Characters such as:

* ` _ " '

don't get auto removed correctly sometimes on pressing backspace.

To fix this we need to determine whether the character being removed is an 'opening' or 'closing' character.

  • Fix single quotes removal
  • Fix double quotes removal
  • Fix asterisk removal
  • Fix backtick removal
  • Fix underscore removal

Note: Looking backward for these characters is temporarily removed until proper solution is implemented.

Note: Commonmark rules for some characters might not completely apply because we are removing only one character at a time. Consider **bold**, we need to handle this in a way that removal of first asterisk results in the removal of third asterisk.

@Waqar144
Copy link
Contributor Author

This is fixed with af48921 so I think its okay to close this for now

@pbek
Copy link
Owner

pbek commented Nov 18, 2020

Fine with me. 😁

@pbek pbek closed this as completed Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants