Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighting support for numbered list checkboxes #134

Closed
pbek opened this issue Apr 25, 2021 · 4 comments
Closed

Highlighting support for numbered list checkboxes #134

pbek opened this issue Apr 25, 2021 · 4 comments
Labels
enhancement

Comments

@pbek
Copy link
Owner

pbek commented Apr 25, 2021

@Waqar144, do you think you can add highlighting support for numbered list checkboxes like 1. [ ] or 25. [x] too in MarkdownHighlighter::highlightLists?
@pbek
Copy link
Owner Author

pbek commented Apr 25, 2021

md4c and Nextcloud Notes are also supporting those...

@pbek
Copy link
Owner Author

pbek commented Apr 25, 2021

And the checkbox toggle from pbek/QOwnNotes#2048 now supports it too. 😉

@Waqar144
Copy link
Contributor

Yeah. Sure. If it's being supported by md4c then we should do it too

@pbek
Copy link
Owner Author

pbek commented Apr 25, 2021

Awesome! 😀

@Waqar144 Waqar144 mentioned this issue Aug 19, 2021
Merged
@pbek pbek closed this as completed Aug 19, 2021
pbek added a commit to pbek/QOwnNotes that referenced this issue Aug 19, 2021
@pbek
Add more highlighting and some fixes (#2205, pbek/qmarkdowntextedit#134)
e6d430d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pbek @Waqar144