Bold italics are not supported

[zh-pan]

If I write Bold&italics, the result is incorrect.

***Bold&italics***

[zh-pan]

[pbek]

I don't think we were supporting mixing styles, did we, @Waqar144?

[Waqar144]

It is supported, try with a different font.

I doubt its broken as the relevant code hasn't been touched in at least a year

[zh-pan]

Thanks reply.
I try debug code, and find something with:

qmarkdowntextedit/markdownhighlighter.cpp

Line 2300 in 17ea661

if (isStrong) {

Code above only bold and italic logical branches, lack mixing styles.
So can you help me how to fix this?

[zh-pan]

I try fix this. And only make little change for supporting mixing styles. The result like this:

But I don't know this change Whether it will bring side effects, because I didn't spend much time looking at the rest of the code.

Can I make a pr?

[Waqar144]

It is broken since 5d990c5.

[Waqar144]

other broken stuff

[zh-pan]

Yes, setFont will override Bold or Italic. So I add a new font BoldItalic. like this:

And BoldItalic:

---

It is broken since 5d990c5.

Or delete the two fmt.setFont can work, too?

[Waqar144]

Font needs to be overwritten only if it was set / different. Just setting the font always is incorrect. You can test with QOwnNotes whether your change works for both cases i.e., when a font is set or not. (Read the linked QOwnNotes issue)

Adding BoldItalic is not needed.

[pbek]

@Waqar144, thank you.
Yes, best investigate in QOwnNotes, if you are using that, @zh-pan.
Those styles were never planned to work in conjunction in QOwnNotes.

[pbek]

And please open an issue in QOwnNotes.

[pbek]

I'll add that with pbek/QOwnNotes#2676.

[Waqar144]

This is a qmarkdowntextedit bug, it can't be fixed in QOwnNotes

[pbek]

Ah, I had to little sleep.

[pbek]

I didn't even saw it was in markdownhighlighter.cpp directly...

[zh-pan]

Yes. You can remove this commit's change(5d990c5 ).

Or make a new format with mixing styles.

[Waqar144]

I think to fix it, one needs to check if the font is something different and then change? like the other checks below. Not sure though

[pbek]

I already fixed it (see screenshot), it's not committed yet.

[pbek]

Should be fixed now.

[zh-pan]

That's great!

[zh-pan]

Windows will be crash when I use this commit. When input the fifth character '*'.
***1*: Note: The last '*' key down will crash.

I want know this isn't my problem?

[zh-pan]

I'm sure this commit caused the error. It also appears when I compile with the original project.

[zh-pan]

I'm sure this commit caused the error. It also appears when I compile with the original project.

• windows 10 LTSC
• vs2022
• Qt6.4

Qt creator will crash, too.

[pbek]

It also appears when I compile with the original project.

What original project?

Qt creator will crash, too.

Qt creator crashes!?

[pbek]

The commit just uses https://doc.qt.io/qt-5/qtextcharformat.html#setFontFamily...

[Waqar144]

Can you use the debugger to get a backtrace when the assert hits?

[zh-pan]

I found problems with using qmarkdowntextedit as a 3rd party library in VS2022, then I tried to build QMarkDowntextedit-exe using the qmarkdowntextedit project and also got an error. I also tested compiling qmarkdowntextedit-exe in Qt creator with the same error. mingw and msvc2019 were used, respectively.

[zh-pan]

[zh-pan]

[pbek]

Hmmm... I don't have any issues under Windows with Qt 5.11.

[pbek]

What's the content of _formats[Bold].fontFamilies() for you if you output it e.g. with qDebug()?

[Waqar144]

He is using Qt 6.4, it will easily crash there

[pbek]

I need to wait until I'll hit a box where I've Qt6 running then...

[Waqar144]

Then best not bump it in QON till its properly fixed.

[pbek]

There is no issue with the Qt5 builds as far as I'm aware of.

[Waqar144]

if there is no qt6 end user build, then it would be fine. But its trivial to fix either ways.

[pbek]

Feel free to make a PR if you have faster access than me to a Qt6 box then. 😉

[Waqar144]

Open up master, i will push a fix ;)

[pbek]

Should be fixed now.