Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Forth Syntax Highlighting #182

Closed
0x3508A opened this issue May 1, 2023 · 3 comments
Closed

Support for Forth Syntax Highlighting #182

0x3508A opened this issue May 1, 2023 · 3 comments

Comments

@0x3508A
Copy link
Contributor

0x3508A commented May 1, 2023

Thanks for creating this very wonderful effective control for Qt.
I am an avid user of the QOwnNotes and a Forth enthusiast.

While adding Forth code, I found that there is no highlighting support.
I wish to request your kind help regarding the same.

In line with this, I have taken a fork and placed in my changes.
Initially, the gforth words are added as the keywords.
There is also addition of special filter functions to help with comment highlighting.

This would be the first time I am trying to contribute to a project.
Please guide me and help me correct my mistakes.

@pbek
Copy link
Owner

pbek commented May 1, 2023

Looking forward to it 😁

pbek added a commit that referenced this issue May 2, 2023
Adding Forth code Highlighting support
@0x3508A
Copy link
Contributor Author

0x3508A commented May 2, 2023

Thanks again for guiding this through.
I have added an issue on the QOwnNotes as well pbek/QOwnNotes#2780
With this issue, I have now learned how to properly commit code that would help the developers to audit and accept features.

Kindly guide me to add the the finally support for Forth Programming language highlighting in QOwnNotes.

@pbek
Copy link
Owner

pbek commented May 2, 2023

Awesome, thank you! I'll close this then.

@pbek pbek closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants