Ignore null characters in PSBaseParser #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beforehand, null characters were encoded as PSKeyword tokens. This caused issue #617, as pdfdevice.py would attempt to decode the null character PSKeyword, when it expects a byte string, as opposed to a PSKeyword, causing pdfminer.six to crash. As null characters are superfluous within PSBaseParser, ignore them.
|
Thanks for figuring this out, proposing the solution and creating the PR! 👏 |
|
And thank you for your work as a maintainer and keeping PDFMiner.six up-to-date! |
Beants
added a commit
to HiTalentAlgorithms/pdfminer.six
that referenced
this pull request
Aug 5, 2022
* commit '8f52578e85b27831ab8a68a6d86721ea3348a553': Run black locally with nox (pdfminer#776) Install typing_extensions on Python 3.6 and 3.7 (pdfminer#775) Fix `TypeError` by Ignoring null characters in PSBaseParser (pdfminer#768) Fix `ValueError` with unencrypted metadata values (Fixes pdfminer#766). (pdfminer#774) Fix `TypeError` when getting default width of font (pdfminer#772) Deprecate usage of `if __name__ == "__main__"` in scripts that are not documented. Also deprecate usage of scripts that are only there for testing purposes. (pdfminer#756) Fix Sphinx warnings and error (pdfminer#760) Update CHANGELOG.md for pdfminer#755 Remove upper version bounds (pdfminer#755) Ignore path constructors that do not begin with m (pdfminer#749) Bump version 20220506 & fix small issue with types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Beforehand, null characters parsed by PSBaseParser were encoded as PSKeyword tokens. This caused issue #617, as pdfdevice.py would attempt to decode the null character PSKeyword, when it expects a byte string, as opposed to a PSKeyword, causing pdfminer.six to crash.
As null characters are superfluous within PSBaseParser, ignore them.
How Has This Been Tested?
A PDF included in issue #617 recreates the bug. With this commit, the bug is fixed.
Checklist
works
version
is not necessary
verified that this is not necessary
CHANGELOG.md