Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX #916: move flate decode to higher priority #917

Closed
wants to merge 2 commits into from
Closed

FIX #916: move flate decode to higher priority #917

wants to merge 2 commits into from

Conversation

dotrunghieu96
Copy link

@dotrunghieu96 dotrunghieu96 commented Nov 8, 2023 •
edited
Loading

Pull request

Fix #916: Move FLATE_DECODE to a higher priority
ImageWriter priortized BMP over FLATE_DECODE so some image in my PDF is saved as bmp directly, which caused them to corrupt.

How Has This Been Tested?

Tested with nox and self test on pdf

Checklist

  • I have read CONTRIBUTING.md.
  • I have added a concise human-readable description of the change to CHANGELOG.md.
  • I have tested that this fix is effective or that this feature works.
  • I have added docstrings to newly created methods and classes.
  • I have updated the README.md and the readthedocs documentation. Or verified that this is not necessary.

@dotrunghieu96 dotrunghieu96 changed the title move flate decode to higher priority FIX #916: move flate decode to higher priority Nov 8, 2023
@pietermarsman
Copy link
Member

Closing because issue cannot be replicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImageWriter save FLATE_DECODE image as BMP makes the output file corrupt
2 participants
@dotrunghieu96 @pietermarsman