Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdm update do not intstall proper revision of git dependency #1762

Closed
1 task done
j1g5awi opened this issue Mar 9, 2023 · 5 comments · Fixed by j178/pdm#1
Closed
1 task done

pdm update do not intstall proper revision of git dependency #1762

j1g5awi opened this issue Mar 9, 2023 · 5 comments · Fixed by j178/pdm#1
Labels
🐛 bug Something isn't working

Comments

@j1g5awi
Copy link

j1g5awi commented Mar 9, 2023

  • I have searched the issue tracker and believe that this is not a duplicate.

it has broken my test action: https://github.com/nonepkg/nonebot-plugin-all4one/actions/runs/4371902592

Steps to reproduce

  1. make a git repo as project's depend.
  2. commit to this repo.
  3. pdm update or pdm sync(when pdm.lock has been updated)

Actual behavior

PDM install the cached version.

Expected behavior

PDM install the latest commited.

Environment Information

# Paste the output of `pdm info && pdm info --env` below:
PDM version:
  2.4.6
Python Interpreter:
  /usr/bin/python (3.10)
Project Root:
  /home/jigsaw/Documents/Program/nonepkg/nonebot-plugin-all4one
Project Packages:
  /home/jigsaw/Documents/Program/nonepkg/nonebot-plugin-all4one/__pypackages__/3.10
{
  "implementation_name": "cpython",
  "implementation_version": "3.10.9",
  "os_name": "posix",
  "platform_machine": "x86_64",
  "platform_release": "6.2.2-arch1-1",
  "platform_system": "Linux",
  "platform_version": "#1 SMP PREEMPT_DYNAMIC Fri, 03 Mar 2023 15:58:31 +0000",
  "python_full_version": "3.10.9",
  "platform_python_implementation": "CPython",
  "python_version": "3.10",
  "sys_platform": "linux"
}
@j1g5awi j1g5awi added the 🐛 bug Something isn't working label Mar 9, 2023
@frostming
Copy link
Collaborator

Actual behavior

PDM install the latest commited.

Expected behavior

PDM install the cached version.

This confuses me, I think installing the latest commit should be desired.

@j1g5awi
Copy link
Author

j1g5awi commented Mar 9, 2023

Actual behavior

PDM install the latest commited.

Expected behavior

PDM install the cached version.

This confuses me, I think installing the latest commit should be desired.

My mistake, their place correct now

@frostming frostming closed this as not planned Won't fix, can't repro, duplicate, stale Mar 9, 2023
@frostming frostming reopened this Mar 9, 2023
@j1g5awi
Copy link
Author

j1g5awi commented Mar 9, 2023

but the lock file has been the latest revision, you can see it :https://github.com/nonepkg/nonebot-plugin-all4one/blob/7196ed10056a65e2eec14da245783d2dcc44406d/pdm.lock#L455 ,and pdm sync still install the cached version

@frostming
Copy link
Collaborator

Do you have any steps I can follow to reproduce locally? I failed to reproduce that

@he0119
Copy link

he0119 commented Mar 9, 2023

I can reproduce this as follows:

  1. git clone https://github.com/nonepkg/nonebot-plugin-all4one.git
  2. git checkout bdd2e2099b8f8a049702122b2ac8300176a244b8
  3. pdm sync -G adapters -G tests -G nonebot
  4. pytest # Everything works
  5. git checkout master
  6. pdm sync -G adapters -G tests -G nonebot
  7. pytest # Tests failed

This is the log for the second pdm sync.

Synchronizing working set with lock file: 0 to add, 2 to update, 0 to remove                                                                                                                            

  ✔ Update nonebot-plugin-datastore 0.6.0a0 -> 0.6.0a2 successful
  ✔ Update fastapi 0.92.0 -> 0.93.0 successful
Installing the project as an editable package...
  ✔ Install nonebot-plugin-all4one 0.1.0a1 successful

🎉 All complete!

It seems pdm sync does not sync the git revision in the lockfile.

pajowu added a commit to bugbakery/transcribee that referenced this issue Mar 24, 2023
2.4.9 fixes a bug that ignored the git rev of a dependency pdm-project/pdm#1762
pajowu added a commit to bugbakery/transcribee that referenced this issue Mar 25, 2023
2.4.9 fixes a bug that ignored the git rev of a dependency pdm-project/pdm#1762
pajowu added a commit to bugbakery/transcribee that referenced this issue Mar 31, 2023
2.4.9 fixes a bug that ignored the git rev of a dependency pdm-project/pdm#1762
pajowu added a commit to bugbakery/transcribee that referenced this issue Apr 3, 2023
2.4.9 fixes a bug that ignored the git rev of a dependency pdm-project/pdm#1762
pajowu added a commit to bugbakery/transcribee that referenced this issue Apr 3, 2023
2.4.9 fixes a bug that ignored the git rev of a dependency pdm-project/pdm#1762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants