Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring log file directory #2398

Closed
sanmai-NL opened this issue Nov 13, 2023 · 0 comments · Fixed by #2687
Closed

Allow configuring log file directory #2398

sanmai-NL opened this issue Nov 13, 2023 · 0 comments · Fixed by #2687
Assignees
@frostming
Labels
⭐ enhancement Improvements for existing features

Comments

@sanmai-NL
Copy link
Contributor

sanmai-NL commented Nov 13, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

Currently, PDM logs effectively in a descendant of /tmp/, or something similar - depending on the operating system and its settings. Some CI systems, such as GitLab CI, can upload logs as job artifacts, yet exclusively from some allowlisted directory (e.g., the Git working copy directory).

Describe the solution you'd like

Allow configuring log file directory, e.g., through a PDM-wide environment variable.

Alternatives

The current log file directory has a randomized path. Finding its path is hard to do automatedly. Even if it were practical, simply copying from source directory to the allowlisted directory is redundant work and adds complexity.
@sanmai-NL sanmai-NL added the ⭐ enhancement Improvements for existing features label Nov 13, 2023
@sanmai-NL sanmai-NL mentioned this issue Dec 8, 2023
Open
@sanmai-NL sanmai-NL mentioned this issue Dec 22, 2023
Closed
2 tasks
@frostming frostming self-assigned this Mar 13, 2024
frostming added a commit that referenced this issue Mar 13, 2024
@frostming
feat: Allow configuring log file directory
1f92b6b 
Fixes #2398

Signed-off-by: Frost Ming <[email protected]>
@frostming frostming mentioned this issue Mar 13, 2024
Merged
2 tasks
frostming added a commit that referenced this issue Mar 13, 2024
@frostming
feat: Allow configuring log file directory (#2687)
1d370a3 
* feat: Allow configuring log file directory

Fixes #2398

Signed-off-by: Frost Ming <[email protected]>

* fix: catch_warnings

Signed-off-by: Frost Ming <[email protected]>
@tobiasdam tobiasdam mentioned this issue Mar 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frostming frostming

Labels
⭐ enhancement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow configuring log file directory pdm-project/pdm
2 participants
@sanmai-NL @frostming