Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override cli flag is not working during building in isolated environments #3113

Closed
reuvenstr opened this issue Aug 18, 2024 · 1 comment · Fixed by #3114
Closed

Override cli flag is not working during building in isolated environments #3113

reuvenstr opened this issue Aug 18, 2024 · 1 comment · Fixed by #3114
Assignees
Labels
🐛 bug Something isn't working

Comments

@reuvenstr
Copy link

  • [ V] I have searched the issue tracker and believe that this is not a duplicate.
pdm.termui: Preparing environment(Isolated mode) for PEP 517 build...
pdm.termui: Saving wheel to cache: <Link https://files.pythonhosted.org/packages/fb/94/44fbbb059fe5d295f1f73e731a0b9c2e1b5073c2c6b58bb9c068715e9b72/ujson-5.4.0.tar.gz (from https://pypi.org/simple/ujson/)>
pdm.termui: Running PEP 517 backend to build a wheel for <Link https://files.pythonhosted.org/packages/fb/94/44fbbb059fe5d295f1f73e731a0b9c2e1b5073c2c6b58bb9c068715e9b72/ujson-5.4.0.tar.gz (from https://pypi.org/simple/ujson/)>
pdm.termui: ======== Start resolving requirements ========
pdm.termui:   setuptools-scm[toml]>=3.4
pdm.termui:   python==3.9.17
pdm.termui:   Adding requirement setuptools-scm[toml]>=3.4
pdm.termui:   Adding requirement python==3.9.17
pdm.termui: ======== Starting round 0 ========
pdm.termui: Pinning: python None
pdm.termui: ======== Ending round 0 ========
pdm.termui: ======== Starting round 1 ========
pdm.termui:   Adding requirement setuptools-scm==8.1.0(from setuptools-scm 8.1.0)
pdm.termui: Pinning: setuptools-scm 8.1.0
pdm.termui: ======== Ending round 1 ========
pdm.termui: ======== Starting round 2 ========
pdm.termui:   Adding requirement packaging>=20(from setuptools-scm 8.1.0)
pdm.termui:   Adding requirement setuptools(from setuptools-scm 8.1.0)
pdm.termui:   Adding requirement typing-extensions; python_version < "3.10"(from setuptools-scm 8.1.0)
pdm.termui:   Adding requirement tomli>=1; python_version < "3.11"(from setuptools-scm 8.1.0)
pdm.termui: Pinning: setuptools-scm 8.1.0
pdm.termui: ======== Ending round 2 ========
pdm.termui: ======== Starting round 3 ========
pdm.termui: Pinning: packaging 24.1
pdm.termui: ======== Ending round 3 ========
pdm.termui: ======== Starting round 4 ========
pdm.termui: Pinning: tomli 2.0.1
pdm.termui: ======== Ending round 4 ========
pdm.termui: ======== Starting round 5 ========
pdm.termui: Pinning: setuptools 72.2.0
pdm.termui: ======== Ending round 5 ========
pdm.termui: ======== Starting round 6 ========
pdm.termui: Pinning: typing-extensions 4.12.2
pdm.termui: ======== Ending round 6 ========
pdm.termui: ======== Starting round 7 ========
pdm.termui: ======== Resolution Result ========
pdm.termui: Stable pins:
pdm.termui:                 python None
pdm.termui:   setuptools-scm[toml] 8.1.0
pdm.termui:         setuptools-scm 8.1.0
pdm.termui:              packaging 24.1
pdm.termui:                  tomli 2.0.1
pdm.termui:             **setuptools 72.2.0**
pdm.termui:      typing-extensions 4.12.2

Steps to reproduce

  1. take pypy 3.9 and try to add ujson-5.4.0 to pyproject.toml
  2. it's tries to build it with newest setuptools but fails, when setuptools limited to <71 everything is fine, but it's can be achieved only directly with pip install command. PDM ignores ovveride flags provided in cli
  1. add ujson 5.4.0 to pypy 3.9 will fail because of setuptools
  2. using PIP_CONSTRAINT env variable same procedure works via pip

Actual behavior

PDM fails to build ujson 5.4.0 in pypy venv

Expected behavior

PDM can build ujson 5.4.0 in pypy venv, or at least will use override flag also for building deps in isolated env

Environment Information

Virtualenv is created successfully at /opt/private/.venv
PDM version:
  2.17.0
Python Interpreter:
  /opt/private/.venv/bin/python (3.10)
Project Root:
  /opt/private
Local Packages:

{
  "implementation_name": "cpython",
  "implementation_version": "3.10.12",
  "os_name": "posix",
  "platform_machine": "x86_64",
  "platform_release": "6.6.26-linuxkit",
  "platform_system": "Linux",
  "platform_version": "#1 SMP Sat Apr 27 04:13:19 UTC 2024",
  "python_full_version": "3.10.12",
  "platform_python_implementation": "CPython",
  "python_version": "3.10",
  "sys_platform": "linux"
}
@reuvenstr reuvenstr added the 🐛 bug Something isn't working label Aug 18, 2024
@reuvenstr reuvenstr changed the title Override cli flag is not working durinc building in isolated environments Override cli flag is not working during building in isolated environments Aug 18, 2024
@frostming frostming self-assigned this Aug 19, 2024
frostming added a commit that referenced this issue Aug 19, 2024
@yuvalrosenberg
Copy link

yuvalrosenberg commented Aug 19, 2024

@frostming thanks :).
can i ask when do you plan to release a version that includes that fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants