Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce unncessary package download for certain commands #1374

Merged
merged 8 commits into from
Sep 9, 2022

Conversation

frostming
Copy link
Collaborator

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Fix #1370

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022

Codecov Report

Base: 83.40% // Head: 83.45% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (78a8beb) compared to base (61f572e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1374      +/-   ##
==========================================
+ Coverage   83.40%   83.45%   +0.05%     
==========================================
  Files          93       93              
  Lines        7730     7731       +1     
  Branches     1821     1823       +2     
==========================================
+ Hits         6447     6452       +5     
+ Misses        905      904       -1     
+ Partials      378      375       -3     
Flag Coverage Δ
unittests 83.27% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/installers/synchronizers.py 82.84% <100.00%> (+0.64%) ⬆️
src/pdm/models/requirements.py 95.79% <100.00%> (+0.55%) ⬆️
src/pdm/resolver/providers.py 93.79% <100.00%> (+0.19%) ⬆️
src/pdm/models/markers.py 77.87% <0.00%> (-0.89%) ⬇️
src/pdm/models/repositories.py 77.59% <0.00%> (-0.83%) ⬇️
src/pdm/models/candidates.py 87.57% <0.00%> (+0.62%) ⬆️
src/pdm/models/caches.py 87.71% <0.00%> (+1.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 1fadb42 into main Sep 9, 2022
@frostming frostming deleted the fix/unnecessary-obtain branch September 9, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git dependencies are re-cloned every time some commands run
2 participants