Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove deprecated config names #1422

Merged
merged 1 commit into from
Oct 7, 2022
Merged

feat: remove deprecated config names #1422

merged 1 commit into from
Oct 7, 2022

Conversation

frostming
Copy link
Collaborator

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Base: 85.54% // Head: 85.52% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (b7b3b7e) compared to base (609d1e9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1422      +/-   ##
==========================================
- Coverage   85.54%   85.52%   -0.02%     
==========================================
  Files          87       87              
  Lines        7587     7570      -17     
  Branches     1779     1774       -5     
==========================================
- Hits         6490     6474      -16     
+ Misses        716      714       -2     
- Partials      381      382       +1     
Flag Coverage Δ
unittests 85.33% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/cli/commands/config.py 96.22% <ø> (+10.07%) ⬆️
src/pdm/project/config.py 89.50% <ø> (-3.32%) ⬇️
src/pdm/cli/options.py 94.89% <100.00%> (+3.63%) ⬆️
src/pdm/models/repositories.py 77.95% <0.00%> (-0.82%) ⬇️
src/pdm/termui.py 90.07% <0.00%> (-0.71%) ⬇️
src/pdm/cli/actions.py 79.95% <0.00%> (-0.24%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 88c01cb into main Oct 7, 2022
@frostming frostming deleted the remove/deprecations branch October 7, 2022 07:36
frostming added a commit that referenced this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants