Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance the pdm list command #1469

Merged
merged 8 commits into from
Oct 31, 2022
Merged

feat: enhance the pdm list command #1469

merged 8 commits into from
Oct 31, 2022

Conversation

frostming
Copy link
Collaborator

@frostming frostming commented Oct 28, 2022

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

  • Improve --sort to accept a comma-separated string
  • Packages are included or excluded in the tree approach, when a package is excluded, all its dependencies are excluded, too.
  • Modify test cases according to the expected behavior

cc @JohnHardy

JohnHardy and others added 3 commits October 28, 2022 10:11
* -Draft licenses CLI feature

* fix field name

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Revised feature set as per discussion in #1433

* Removed licenses preview feature

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* --resolve applies to graph

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* special label

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Refactored and added tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* a few static check fixes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Added more tests and fixed linting

* ignore type issues on PackageMetadata

* interim test cases fixes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* added missing slashes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* removed ide addons

* updated tests

* Changed from do_list to do_lock but reverted exception checking

* Added --freeze and tests

* Reverted

* Fixed spelling in argparse commands

* Graph output tests using ascii

* Removed todo comment

* Black formatting

* test_list_csv_include_exclude updated

* test_list_csv_include_exclude updated

* added note for expected version

* Minor updates

* Fixed selection and hopefully list tests on posix

* Typing fix on parse_comma_separated_string

* Typing fix on parse_comma_separated_string

* Typing fix on parse_comma_separated_string

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022

Codecov Report

Base: 84.97% // Head: 85.20% // Increases project coverage by +0.22% 🎉

Coverage data is based on head (449887b) compared to base (1e5dc62).
Patch coverage: 91.62% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1469      +/-   ##
==========================================
+ Coverage   84.97%   85.20%   +0.22%     
==========================================
  Files          88       88              
  Lines        7662     7852     +190     
  Branches     1798     1859      +61     
==========================================
+ Hits         6511     6690     +179     
- Misses        766      775       +9     
- Partials      385      387       +2     
Flag Coverage Δ
unittests 85.01% <91.62%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/cli/actions.py 79.46% <ø> (-1.05%) ⬇️
src/pdm/cli/commands/list.py 91.78% <91.41%> (-8.22%) ⬇️
src/pdm/cli/utils.py 82.74% <93.33%> (+3.59%) ⬆️
src/pdm/installers/uninstallers.py 80.62% <100.00%> (+0.20%) ⬆️
src/pdm/models/working_set.py 67.44% <0.00%> (-2.33%) ⬇️
src/pdm/models/repositories.py 78.04% <0.00%> (-0.82%) ⬇️
src/pdm/termui.py 89.85% <0.00%> (-0.73%) ⬇️
src/pdm/models/requirements.py 95.10% <0.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 58f3855 into main Oct 31, 2022
@frostming frostming deleted the feat/licenses branch October 31, 2022 02:46
frostming added a commit that referenced this pull request Oct 31, 2022
@JohnHardy
Copy link
Contributor

Thanks very much!

@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants