Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve the error report for resolution #1519

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Conversation

frostming
Copy link
Collaborator

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2022

Codecov Report

Base: 85.35% // Head: 85.31% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (3290273) compared to base (c12422f).
Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1519      +/-   ##
==========================================
- Coverage   85.35%   85.31%   -0.04%     
==========================================
  Files          91       91              
  Lines        8001     8007       +6     
  Branches     1897     1899       +2     
==========================================
+ Hits         6829     6831       +2     
- Misses        783      786       +3     
- Partials      389      390       +1     
Flag Coverage Δ
unittests 85.13% <90.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/cli/utils.py 82.74% <0.00%> (ø)
src/pdm/models/candidates.py 87.98% <100.00%> (+0.18%) ⬆️
src/pdm/resolver/providers.py 95.38% <100.00%> (ø)
src/pdm/resolver/reporters.py 97.77% <100.00%> (+0.05%) ⬆️
src/pdm/models/repositories.py 79.92% <0.00%> (-0.79%) ⬇️
src/pdm/termui.py 89.85% <0.00%> (-0.73%) ⬇️
src/pdm/cli/actions.py 78.50% <0.00%> (-0.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 9d0b2e0 into main Nov 17, 2022
@frostming frostming deleted the fix/resolve-reporter branch November 17, 2022 08:35
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants