Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support relative paths in build requires #1561

Merged
merged 4 commits into from
Dec 9, 2022

Conversation

frostming
Copy link
Collaborator

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Close #1560

@frostming frostming changed the title Relative-path-in-build-requires fix: support relative paths in build requires Dec 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Base: 85.31% // Head: 85.22% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (30f16f0) compared to base (67ee5da).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1561      +/-   ##
==========================================
- Coverage   85.31%   85.22%   -0.09%     
==========================================
  Files          91       91              
  Lines        8062     8063       +1     
  Branches     1910     1911       +1     
==========================================
- Hits         6878     6872       -6     
- Misses        794      798       +4     
- Partials      390      393       +3     
Flag Coverage Δ
unittests 85.05% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/installers/core.py 100.00% <ø> (ø)
src/pdm/models/repositories.py 79.21% <0.00%> (-1.50%) ⬇️
src/pdm/models/caches.py 87.71% <0.00%> (-1.17%) ⬇️
src/pdm/termui.py 89.85% <0.00%> (-0.73%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 0762b95 into main Dec 9, 2022
@frostming frostming deleted the relative-path-in-build-requires branch December 9, 2022 03:07
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in relative paths in build dependencies in PDM 2.3.x
2 participants